Skip to content

fix(hostname): go1.27 idna valid label no longer tolerates trailing d… - #297

Merged
fredbi merged 1 commit into
go-openapi:masterfrom
fredbi:fix/hostname-go1.27
Aug 22, 2026
Merged

fix(hostname): go1.27 idna valid label no longer tolerates trailing d…#297
fredbi merged 1 commit into
go-openapi:masterfrom
fredbi:fix/hostname-go1.27

Conversation

@fredbi

@fredbi fredbi commented Aug 22, 2026

Copy link
Copy Markdown
Member

…ot in hosts

We keep our existing behavior (follows https://url.spec.whatwg.org/#concept-host-parser) and trim any trailing dot before submitting the string to idna label check.

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

…ot in hosts

We keep our existing behavior (follows https://url.spec.whatwg.org/#concept-host-parser)
and trim any trailing dot before submitting the string to idna label
check.

Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.13%. Comparing base (bdd8638) to head (43e75f0).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
format.go 33.33% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   85.97%   89.13%   +3.16%     
==========================================
  Files          24       24              
  Lines        2958     2926      -32     
==========================================
+ Hits         2543     2608      +65     
- Misses        305      317      +12     
+ Partials      110        1     -109     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@fredbi
fredbi merged commit 1eadd70 into go-openapi:master Aug 22, 2026
27 of 28 checks passed
@fredbi
fredbi deleted the fix/hostname-go1.27 branch August 22, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant