Handle quotes in fingerprint source paths - #3014
Open
justadityaraj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fingerprint source globs are expanded after Task joins them to the task directory. The existing path escaping handled spaces and several shell metacharacters, but not a single quote, so an absolute directory such as
test'dwas parsed as unterminated shell syntax. The glob error is swallowed by the fingerprint layer, leaving no source matches and causing the task to rebuild every time.Fixes #2874
Changes
User impact
sourcesandgenerateswork normally when any directory in their absolute path contains a single quote.Verification
go test ./internal/fingerprint -count=1: passedgo vet ./...: passedgo test ./... -count=1: all changed-package tests passed; the root package retains the same 16 Windows-only failures seen on cleanmainfrom unavailable POSIX commands and symlink behaviorAI usage
OpenAI Codex assisted with tracing, implementation, and tests. The complete two-file diff was inspected and the issue's reproducer was verified before submission.