Repository navigation
Use generic tax labels for combined tax totals - #1527
Open
pbennett1-godaddy wants to merge 2 commits into
Open
pbennett1-godaddy wants to merge 2 commits into
pbennett1-godaddy wants to merge 2 commits into
Conversation
The estimated taxes line shows the combined tax total, so naming a single tax (GST, VAT, TVA) is inaccurate where several taxes apply, e.g. a Canadian checkout served enAu showed "Estimated GST" for GST + PST/QST/HST. - enAu: replace GST wording with generic tax wording - enUs/frCa: "Taxes included" / "Taxes incluses" for included taxes - Add enCa localization so Canadian checkouts don't borrow enAu Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 368e65a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sbolinger-godaddy
approved these changes
Nov 2, 2026
sbolinger-godaddy
left a comment
sbolinger-godaddy
left a comment
Collaborator
There was a problem hiding this comment.
Nothing major found, approving! Thanks for tidying these up. A few small items you may want to address, but none are blockers:
esUs.ts:175still hasvatIncluded: 'IVA incluido', the same US/VAT mismatch fixed inenUs. Maybe'Impuestos incluidos'?qaPs.ts:174('[VÂŢ îñçlüdëd]') no longer matches the newenUswording.- Adding the
enCaexport is arguably aminorchangeset rather thanpatch. - For the Canadian merchant, the full fix depends on the host switching from
enAutoenCa, since nothing in this repo picks a locale by country. A follow-up there may be worth tracking.
What I checked:
- Diffed
enCaagainstenUs: only the region, postal code, phone and catalogue strings differ, with no US-only wording left over. - Grepped every locale's tax strings. The other single-tax labels (VAT, MwSt, IVA, GST for SG) look right for their countries.
- Ran the localizations build and typecheck, the react typecheck, and
checkout-totals-summary.test.tsx(17/17) locally.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The checkout's estimated taxes line (
totals.estimatedTaxes) shows the combined tax total, but some localizations named a single tax. A merchant reported that Canadian checkouts showed "Estimated GST". GST is only the federal tax; most provinces add PST, QST, or charge HST instead, so the label understated what was included.estimatedTaxes,vatIncluded,payment.tax,TAX_CALCULATION_ERROR, andTAX_SERVICE_UNAVAILABLE. The labels now say "Estimated taxes", "Taxes included", and so on, which is still correct for Australia.vatIncludedchanges from "VAT included" to "Taxes included", since the US has no VAT.vatIncludedchanges from "TVA incluse" to "Taxes incluses", since TVA is the France term.enUs, with province/territory, postal code, "catalogue", and a Canadian phone placeholder. Hosts that serveenAufor Canada should switch toenCa.enIe("Estimated VAT") is accurate for Ireland and is unchanged.Testing
pnpm --filter @godaddy/localizations buildandtypecheckpasspnpm --filter @godaddy/react typecheckpasses;testpasses (872/872)🤖 Generated with Claude Code