Add Mutex from upstream Godot, and put the upstream Mutex into CoreBind - #2032
Merged
Conversation
Ivorforce
added
bug
…oreBind`. Co-authored-by: David Snopek <dsnopek@gmail.com>
dsnopek
approved these changes
Jul 27, 2026
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
I haven't tested, but this looks good to me. I like the godot::CoreBind namespace - I wonder if we should use that for our ClassDBSingleton too? It's similarly the bound version, and then we have a custom version (which forwards to the bound version on some methods)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_THREAD_SAFE_CLASS_and related macros #2026 (test copied from there)As mentioned in #2026, using the bound mutex is suboptimal because it's heap allocated (must be used with
Ref) and unnecessarily slow.Instead, this syncs the upstream
Mutex, and moves the exposed upstream one intoCoreBind, matching upstream itself.