Repository navigation
Conversation
dsnopek
added
enhancement
…ical,get_ellipsis_glyphs}` for gdextensions to use. Co-authored-by: bruvzg <7645683+bruvzg@users.noreply.github.com>
BenLubar
force-pushed
the
text-server-gdextension-nocopy-get-glyphs
branch
from
October 25, 2026 22:42
4916e59 to
238c810
Compare
BenLubar
changed the title
TextServer::shaped_text_{get_glyphs,sort_logical,get_ellipsis_glyphs} for gdextensions to use.GDExtensionPtr<T>
BenLubar
marked this pull request as ready for review
October 26, 2026 14:16
Contributor
Author
|
@dsnopek I believe the new version of the patch no longer needs the "waiting for Godot" label |
dsnopek
removed
the
waiting for Godot
dsnopek
approved these changes
Oct 30, 2026
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I haven't tested, but these changes look good to me :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
godot-cpp side of godotengine/godot#124561
Previous title:
This should be safe to merge first as (thanks to @bruvzg's patch) it doesn't do anything related to TextServer directly anymore.