Skip to content

Sync Color OKHSL API with upstream Godot. - #2082

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
realybin:color-okhsl
Oct 30, 2026
Merged

dsnopek merged 1 commit into
godotengine:masterfrom
realybin:color-okhsl

Conversation

@realybin

Copy link
Copy Markdown
Contributor

I also ignored thirdparty in pre-commit(from Godot).

@realybin
realybin requested a review from a team as a code owner October 27, 2026 19:57
@dsnopek

dsnopek commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Thanks! The changes look good to me :-)

Could you also start an include/godot_cpp/thirdparty/README.md like Godot's thirdparty/README.md and include information about this dependency?

Signed-off-by: realybin <realybin@qq.com>
@realybin

Copy link
Copy Markdown
Contributor Author

Sure!😀 I added.

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou added the bug This has been identified as a bug label Oct 28, 2026
@dsnopek dsnopek added this to the 10.x milestone Oct 30, 2026
@dsnopek
dsnopek merged commit 4159e7d into godotengine:master Oct 30, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing OKHSL related bindings

3 participants