security: fix 7 dep advisories + pin CI actions (drop exclusion) - #106
Merged
Conversation
brace-expansion/js-yaml/undici/fast-uri/ip-address/nanoid patched, and deepmerge-ts forced to 8 (via Prisma; generate+build verified). Audit gate passes with no allowlisting.
Pin every Action to a commit SHA (mutable tags are the tj-actions-style supply-chain vector), add a dependabot cooldown, and drop the Semgrep exclusion now the findings are genuinely resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
"Check for security and dependency issues and fix them" — and this replaces the Semgrep exclusion from #94 with actual fixes.
Dependency advisories — 7 new HIGH, all fixed (zero allowlisting)
Since the last green run, 7 high advisories landed in the transitive tree (
brace-expansion,js-yaml,undici,fast-uri,ip-addressSSRF,nanoid,deepmerge-ts). All resolved to patched versions:npm audit fix(overrides forfast-uri/brace-expansion/etc.;js-yaml/undici/ip-address/nanoidpatched in range)deepmerge-ts(transitive via Prisma) → forced to^8.0.1viaoverrides; Prismagenerate+ build verified to survive the major. Reachability was uncertain (a deeply-nested tRPC input could reach it through Prisma), so I fixed it rather than accept it.Audit gate now passes with no new allowlist entries.
CI supply-chain — the proper fix for the Semgrep findings you flagged
@vNtags are exactly thetj-actions/changed-files(Mar 2025) vector — a repointed tag runs attacker code with your CI secrets, incl.DEPLOY_SSH_KEY.cooldown(default-days: 7; 2-day for npm patches) so a just-published, possibly-compromised release isn't adopted instantly.--exclude-rulelines from ci: exclude Semgrep CI-hygiene rules from gate #94 — the gate is honest again.Verified
npm auditgate: pass, 0 allowlistedtsc,npm run build,prisma generate, 85 tests — all cleandependabot.ymlparse valid🤖 Generated with Claude Code