Skip to content

fix(workflows): allowlist activate_skill and mcp_github_* in pr-review example - #538

Open
sumit-2007-git wants to merge 3 commits into
google-github-actions:mainfrom
sumit-2007-git:fix/pr-review-tools-core-allowlist
Open

sumit-2007-git wants to merge 3 commits into
google-github-actions:mainfrom
sumit-2007-git:fix/pr-review-tools-core-allowlist

Conversation

@sumit-2007-git

Copy link
Copy Markdown

Summary

Fixes #532

In .github/workflows/gemini-review.yml and examples/workflows/pr-review/gemini-review.yml, "tools": { "core": [] } was configured. Because tools.core acts as an allowlist, passing an empty array emits a wildcard deny in the tool policy engine that disables all MCP tools (including the github-mcp-server tools needed for posting reviews) as well as the mandatory activate_skill tool.

This PR updates tools.core to explicitly allowlist "activate_skill" and "mcp_github_*", ensuring the action can discover and invoke the tools required to post PR reviews.

@sumit-2007-git

Copy link
Copy Markdown
Author

Hi @R2wenD2 @CallumHYoung @adamfweidman @kkarrenn — polite follow-up for review when anyone has a chance. All CI checks are passing and the branch merges cleanly. Happy to adjust anything if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

pr-review example ships tools.core: [] which disables all MCP tools since gemini-cli v0.41.0 – workflow green but no review posted

1 participant