fix: remove unused flutter_localizations dependency - #339
Open
stephenmcd wants to merge 1 commit into
Open
Conversation
pay and pay_android declared flutter_localizations as a dependency without importing or using it anywhere in lib/. Since it's an SDK package, its version is pinned to whatever intl version ships with the developer's installed Flutter SDK, which conflicts with apps that depend on a different intl version and breaks `pub get`/`pub add pay` for no functional benefit to the plugin. Fixes #260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pay and pay_android declared flutter_localizations as a dependency without importing or using it anywhere in lib/. Since it's an SDK package, its version is pinned to whatever intl version ships with the developer's installed Flutter SDK, which conflicts with apps that depend on a different intl version and breaks
pub get/pub add payfor no functional benefit to the plugin.Fixes #260
Describe the changes proposed
A clear and concise description of the changes included in this pull request.
Screenshots / Videos
If useful, include any screeshots or screencasts to better explain the change.
Additional context
Add any other context about the change here.