Skip to content

fix: remove unused flutter_localizations dependency - #339

Open
stephenmcd wants to merge 1 commit into
mainfrom
fix/issue-260-unused-flutter-localizations
Open

fix: remove unused flutter_localizations dependency#339
stephenmcd wants to merge 1 commit into
mainfrom
fix/issue-260-unused-flutter-localizations

Conversation

@stephenmcd

Copy link
Copy Markdown
Contributor

pay and pay_android declared flutter_localizations as a dependency without importing or using it anywhere in lib/. Since it's an SDK package, its version is pinned to whatever intl version ships with the developer's installed Flutter SDK, which conflicts with apps that depend on a different intl version and breaks pub get/pub add pay for no functional benefit to the plugin.

Fixes #260

⚠️
Hello, and thank you for your contributions!

Please review the following checklist before creating a new pull request:

  • Review and contribute to existing pull requests and open issues to avoid redundant efforts.
  • Read the contribution guidelines.
  • Assign reviewers.
  • If applicable, include a reference to related issues.
  • If this is a new feature, create an issue and coordinate with other contributors to make sure the feature can be made available in all platforms supported.

⚠️ Delete this block before creating the pull request.

Describe the changes proposed

A clear and concise description of the changes included in this pull request.

Screenshots / Videos

If useful, include any screeshots or screencasts to better explain the change.

Additional context

Add any other context about the change here.

pay and pay_android declared flutter_localizations as a dependency
without importing or using it anywhere in lib/. Since it's an SDK
package, its version is pinned to whatever intl version ships with
the developer's installed Flutter SDK, which conflicts with apps
that depend on a different intl version and breaks `pub get`/`pub
add pay` for no functional benefit to the plugin.

Fixes #260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The current Dart SDK version is 3.3.4.

1 participant