You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Follow-up: allow safe data:image/* schemes via url_filter in SVG sanitizer #5851
The SVG sanitizer added in that fix currently blocks every data: URL inside SVG attributes (href, xlink:href, etc.) as a conservative default. That's the right call for the immediate XSS fix — data:image/svg+xml and data:text/html are real vectors, and dropping them outright avoids whack-a-mole on MIME parsing edge cases.
Per @'s comment (#5514 (comment)), opening this so the narrower whitelist doesn't get forgotten.
What's left to do
Wire a url_filter (or equivalent attribute callback) into the sanitizer so the scheme check can distinguish safe raster MIME types from script-capable ones:
keep blocking: javascript:, vbscript:, plain data: with no MIME, MIME with stray whitespace/control chars
Why it's worth doing later (not now)
In ADK today, raster artifacts surface as their own image/* blobs rather than embedded inside SVG, so the current block doesn't degrade the dev UI. But once user-supplied SVGs from external sources show up (e.g., LLM-generated diagrams that inline a small PNG legend), the strict block will start cutting legitimate content. Better to land the relaxation behind a tested filter than to loosen the regex under pressure.
Hi @jeongbeannnn , Thanks for the update. The request is currently being reviewed by our team, and we will let you know if anything further is needed. Thank you for understanding.
no svg sanitizer ever landed here. #5515 was closed on 11 september on the view that ad-hoc svg sanitization is the wrong mitigation, and #5514 was fixed in google/adk-web#514, which downgrades scriptable artifact blobs so they download instead of rendering.
so there's nothing with a url_filter to relax. closing because the approach this tracks was dropped, not because the analysis was wrong. open a new issue if an svg still renders on a current version.
Activity
sanketpatil06 commentedon May 26, 2026
Hi @jeongbeannnn , Thanks for the update. The request is currently being reviewed by our team, and we will let you know if anything further is needed. Thank you for understanding.
GWeale commentedon Sep 16, 2026
no svg sanitizer ever landed here. #5515 was closed on 11 september on the view that ad-hoc svg sanitization is the wrong mitigation, and #5514 was fixed in google/adk-web#514, which downgrades scriptable artifact blobs so they download instead of rendering.
so there's nothing with a url_filter to relax. closing because the approach this tracks was dropped, not because the analysis was wrong. open a new issue if an svg still renders on a current version.