test(models): remove obsolete shadowed instruction tests - #6922
Open
kikifrost wants to merge 1 commit into
Open
Conversation
Four superseded append_instructions tests were hidden by later definitions with the same names. Remove the obsolete copies so the collected tests reflect the current string-only behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tests/unittests/models/test_llm_request.pydefines fourtest_append_instructions_*tests twice. Python keeps the later bindings, sothe older definitions are never collected.
Those older assertions target the previous
types.Contentbehavior. Renamingthem so pytest can collect them produces 4 failures while the 33 current tests
continue to pass.
Change
Remove the four superseded definitions. The updated tests for the current
string-only
append_instructionsbehavior remain unchanged, and the collectedtest count stays at 33.
Testing plan
4 failed, 33 passedpytest tests/unittests/models/test_llm_request.py -q:33 passedpre-commit run --files tests/unittests/models/test_llm_request.py: all checks passed