Qualify static field references when generating @InlineMe annotations. - #6025
Merged
Conversation
Previously, `ImportAndQualificationFinder` skipped identifiers whose parent node was a `MemberSelectTree`. When an unqualified static field was the receiver of a member selection (such as `STR.length()` or `MAGIC.get()`), this check caused `InlineMe` to leave the field reference unqualified and omit the required class import. We now handle `ClassSymbol` explicitly and ensure static fields on the enclosing class are correctly qualified with the class name and the class is added to imports. PiperOrigin-RevId: 964277465
copybara-service
Bot
force-pushed
the
test_964218200
branch
from
August 13, 2026 20:58
79acb7e to
bcc3cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qualify static field references when generating
@InlineMeannotations.Previously,
ImportAndQualificationFinderskipped identifiers whose parent nodewas a
MemberSelectTree. When an unqualified static field was the receiver of amember selection (such as
STR.length()orMAGIC.get()), this check causedInlineMeto leave the field reference unqualified and omit the required classimport.
We now handle
ClassSymbolexplicitly and ensure static fields on the enclosingclass are correctly qualified with the class name and the class is added to
imports.