Skip to content

chore: Fix flaky unit test#4374

Merged
gmlewis merged 1 commit into
google:masterfrom
gmlewis:fix-flaky-unit-test
Jul 9, 2026
Merged

chore: Fix flaky unit test#4374
gmlewis merged 1 commit into
google:masterfrom
gmlewis:fix-flaky-unit-test

Conversation

@gmlewis

@gmlewis gmlewis commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

This fixes the flaky unit test demonstrated here:
https://github.com/google/go-github/actions/runs/28966637656/job/85951381658

    --- FAIL: TestDo_rateLimit_abortSleepContextCancelled (0.05s)
        github_test.go:2873: Expected 1 requests, got 0
    FAIL

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 8, 2026
@gmlewis

gmlewis commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.51%. Comparing base (da81e17) to head (b4f4800).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4374   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         193      193           
  Lines       19526    19526           
=======================================
  Hits        19040    19040           
+ Misses        269      268    -1     
- Partials      217      218    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevehipwell stevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis merged commit 9b2c665 into google:master Jul 9, 2026
15 checks passed
@gmlewis gmlewis deleted the fix-flaky-unit-test branch July 9, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants