-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: Add MergeAsync and GetMergeAsyncResult support
#4491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ymh3090
wants to merge
7
commits into
google:master
Choose a base branch
from
ymh3090:feat/merge-async
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+436
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
faac0a5
feat: add MergeAsync and GetMergeAsyncResult support
ymh3090 1400fd8
docs: fix doc comment grammar
ymh3090 eae8950
Update github/pulls.go
ymh3090 3ac2d18
Update github/pulls.go
ymh3090 01bf9d3
refactor: rename async merge types for consistency
ymh3090 1a2d3d1
Merge branch 'master' into feat/merge-async
ymh3090 c2cab06
Merge branch 'master' into feat/merge-async
gmlewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This endpoint can return a 202
AcceptedError- other places where this happens is either handled in the function or documented in the function docs. Not sure what the maintainers prefer but we should do something hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like adding a comment in the function docs would be sufficient here - do you agree, @DP19?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah maybe it should be handled in the function just based on a previous bug #3036 / #3047 - the doc might be fine as long as people don't care about the response in that case. Up to you all!
@gmlewis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an asynchronous call anyway, I think a comment should be just fine. In those other examples, users were waiting for the upload, but here, they are explicitly calling an async endpoint anyway and are planning on waiting. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup that works for me 👍🏻