Add tld,domain_name idx on Domain for RDAP searches - #3200
Merged
Conversation
this allows us to quickly serve requests like "*.tld" which we need to order to allow for cursored results b/535250462
gbrodman
force-pushed
the
tldDomainNameIndex
branch
from
August 5, 2026 12:44
7f3ac8d to
55edaa3
Compare
jicelhay
approved these changes
Aug 5, 2026
jicelhay
left a comment
jicelhay
left a comment
Collaborator
There was a problem hiding this comment.
I'm not a SQL expert to fully judge if the load of building the index will impact the DB, besides that, LGTM.
@jicelhay reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
gbrodman
commented
Aug 5, 2026
gbrodman
left a comment
gbrodman
left a comment
Collaborator
Author
There was a problem hiding this comment.
"Concurrently" means non-blocking (which is necessary, yeah)
@gbrodman made 1 comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows us to quickly serve requests like "*.tld" which we need to order to allow for cursored results
b/535250462
This change is