Conversation
G-Rath
changed the title
G-Rath
force-pushed
the
fallback-to-description
branch
4 times, most recently
from
September 22, 2026 19:14
0ff6c51 to
478d3a1
Compare
Collaborator
Author
|
@another-rex I think I've done this right so hopefully the failures are unrelated, but afaik I cannot access the logs to see for myself 😅 |
Contributor
|
Hmm I can't seem to see the test errors either??? This is quite weird. |
another-rex
reviewed
Sep 28, 2026
| vuln := &osvschema.Vulnerability{ | ||
| Id: "TEST-123", | ||
| Published: timestamppb.New(time.Date(2025, time.January, 1, 0, 0, 0, 0, time.UTC)), | ||
| Summary: "This is a vuln", |
Contributor
There was a problem hiding this comment.
The test error is just you filled out the summaries, so it doesn't take from description
Collaborator
Author
There was a problem hiding this comment.
yup ok I completely forgot to update all these tests 🤦
G-Rath
force-pushed
the
fallback-to-description
branch
from
September 28, 2026 00:56
a3fd32d to
eabca2a
Compare
G-Rath
commented
Sep 28, 2026
| summary = vuln.GetDetails() | ||
|
|
||
| if summary != "" { | ||
| summary = truncate(summary) |
Collaborator
Author
There was a problem hiding this comment.
tbh it might be worth truncating in all cases?
Collaborator
Author
There was a problem hiding this comment.
@another-rex does thumbs up mean you want me to do that? 😄
another-rex
approved these changes
Sep 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves DrupalSecurityTeam/drupal-advisory-database#232