Skip to content

refactor: Migrate vanir signature orchestrator to Go - #6066

Merged
michaelkedar merged 4 commits into
google:masterfrom
michaelkedar:😁🐹💱🐍
Sep 29, 2026

Hidden character warning

The head ref may contain hidden characters: "\ud83d\ude01\ud83d\udc39\ud83d\udcb1\ud83d\udc0d"
Merged

michaelkedar merged 4 commits into
google:masterfrom
michaelkedar:😁🐹💱🐍

Conversation

@michaelkedar

@michaelkedar michaelkedar commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

To enable database migration (i.e. to avoid having to support database interactions in Python), rewrite the Vanir signature generation job to be orchestrated by a go program, which shells out to Python to run the signature generation on the records.

  • New vanir_signatures go command (and build in Dockerfile)
  • New generate_signatures.py Python script + poetry lockfile for vanir dependencies
  • Added new JobData database interface and new Mutate and list-after-modified interfaces on Vulnerability interface to support Vanir operations
  • Deleted old Vanir code, updated documentation

@michaelkedar
michaelkedar requested a review from cuixq September 25, 2026 01:03

@cuixq cuixq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Comment thread go/internal/vanir/generator.go
Comment thread go/internal/database/datastore/vulnerability.go Outdated

@cuixq cuixq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelkedar

Copy link
Copy Markdown
Member Author

we probably need to update https://github.com/google/osv.dev/blob/master/docs/contributing/architecture.md#auxiliary-services-python-based too.

I did?

@michaelkedar
michaelkedar enabled auto-merge (squash) September 29, 2026 05:09
@michaelkedar
michaelkedar merged commit d91d9c9 into google:master Sep 29, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants