fix(bigtable): safely handle error states in metadata retrieval

[colinmoy]

Fixes a potential undefined behavior/crash where source_ (a nested std::optional<StatusOr<...>>) was being dereferenced without checking if the underlying StatusOr holds an error

fixes #16222

[gemini-code-assist]

Code Review

This pull request contains unresolved git conflict markers in google/cloud/bigtable/internal/data_connection_impl.cc within the Metadata() method. The reviewer correctly identified this issue, which would cause compilation to fail, and provided a clear suggestion to resolve the conflict by keeping the absl::optional signature while incorporating the new safety check.

[gemini-code-assist]

Unresolved git conflict markers are present in the code. This will cause compilation to fail. Please resolve the conflict by keeping the absl::optional signature (as required by the base class override) while incorporating the safety check for !source_->ok().

  absl::optional<google::bigtable::v2::ResultSetMetadata> Metadata() override {
    if (!source_.has_value() || !source_->ok()) return absl::nullopt;

References

1. Prefer defensive code, such as explicit ok() checks, even if they seem redundant based on the current implementation of a framework, as the framework's contract may change in the future.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.24%. Comparing base (e0b2850) to head (b6f1f5e).
⚠️ Report is 17 commits behind head on main.

Files with missing lines	Patch %	Lines
...le/cloud/bigtable/internal/data_connection_impl.cc	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16225      +/-   ##
==========================================
- Coverage   92.24%   92.24%   -0.01%     
==========================================
  Files        2265     2265              
  Lines      210126   210126              
==========================================
- Hits       193839   193829      -10     
- Misses      16287    16297      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.