chore(storage): migrate to std::optional#16229
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the codebase from absl::optional to std::optional across various files in the Google Cloud Storage library, benchmarks, and tests. The review identified two critical issues: a missing # symbol in the #include <optional> directive in bucket_cors_entry.h which will cause a compilation error, and an incorrect attempt to link std::optional as a CMake target in google_cloud_cpp_storage_grpc.cmake instead of simply removing the absl::optional dependency.
| #include "absl/types/optional.h" | ||
| #include <cstdint> | ||
| #include <iosfwd> | ||
| include <optional> |
| gRPC::grpc++ | ||
| absl::optional | ||
| std::optional |
2054cb0 to
6c4507d
Compare
6c4507d to
a362644
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16229 +/- ##
==========================================
- Coverage 92.24% 92.24% -0.01%
==========================================
Files 2265 2265
Lines 210126 210123 -3
==========================================
- Hits 193833 193826 -7
- Misses 16293 16297 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Replacing explicit usages of absl::optional with std::optional in the Storage Client library as part of broader modernization efforts