refactor(bigquery): resolve circular test dependency with bigquerystorage - #13949
refactor(bigquery): resolve circular test dependency with bigquerystorage#13949jinseopkim0 wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restructures the project by moving integration tests from java-bigquerystorage to java-bigquery, updating the respective pom.xml dependencies, and adjusting the Kokoro build script to trigger java-bigquery tests when java-bigquerystorage is modified. Feedback suggests replacing the Bash string-matching array membership check with a more robust loop to avoid anti-patterns, and warns against manually editing auto-generated pom.xml files to prevent changes from being overwritten.
…res in BQ Storage
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request moves several integration tests from java-bigquerystorage to java-bigquery, updating the respective Maven configurations and the Kokoro build script to handle dependencies and module detection. Feedback suggests simplifying the duplicate-checking logic in .kokoro/common.sh using bash regex patterns and adding the arrow-memory-netty test dependency to java-bigquery's POM to prevent initialization errors during Arrow-based test execution.
1 participant
Fixes #12700.
Moves all integration tests depending on java-bigquery veneer client from java-bigquerystorage to java-bigquery to eliminate circular test dependency.