fix: add documentation for insertall api that there's no default retry - #13953
fix: add documentation for insertall api that there's no default retry#13953GaoleMeng wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Javadoc documentation to the insertAll method in BigQueryImpl to clarify retry behavior and exception handling. The reviewer noted that since BigQueryImpl is an internal implementation class, this documentation should be moved or copied to the BigQuery interface so that it is visible to library consumers in their IDEs.
| /** | ||
| * Inserts the specified rows into a table using the BigQuery insertAll API. | ||
| * Note: To prevent duplicate rows, this method does not perform automatic retries unless | ||
| * insert IDs are provided. Transient service errors (such as UNAVAILABLE) may be thrown and | ||
| * should be handled by the caller. | ||
| */ |
There was a problem hiding this comment.
This Javadoc contains crucial information about the retry behavior and exception handling of the insertAll API. However, because BigQueryImpl is an internal implementation class, developers using this library typically interact with the BigQuery interface. Javadoc placed here will not be visible to users in their IDEs when calling BigQuery.insertAll(...). Please move or copy this Javadoc documentation to the insertAll(InsertAllRequest) method in the BigQuery interface so that it is properly exposed to library consumers.
1 participant
Add documentation for insertall that there's no default behavior