fix(gax-httpjson): reduce Conscrypt fallback error to debug level - #13962
Open
lqiu96 wants to merge 2 commits into
Open
fix(gax-httpjson): reduce Conscrypt fallback error to debug level#13962lqiu96 wants to merge 2 commits into
lqiu96 wants to merge 2 commits into
Conversation
… Conscrypt fallbacks at WARNING level
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies HttpJsonConscryptUtils.java to adjust logging behavior when Conscrypt initialization or socket group configuration fails. Specifically, it splits the warning logs to avoid printing full exception stack traces at the WARNING level, instead logging the stack traces at the FINE level. There are no review comments, and the changes look appropriate, so I have no additional feedback to provide.
lqiu96
changed the title
lqiu96
marked this pull request as ready for review
July 30, 2026 21:00
lqiu96
enabled auto-merge (squash)
July 30, 2026 21:01
|
blakeli0
approved these changes
Jul 30, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.