Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for conditional row mutations (CheckAndMutateRow) in the session-based data path of the Google Cloud Bigtable Java client. It introduces CheckAndMutateRowShim to route conditional mutations to tables and authorized views, and updates the session-based classes (TableAsync, AuthorizedViewAsync, TableBase, and VRpcDescriptor) to handle the new request and response types. Feedback on the changes suggests passing debugTagTracer to DivertingUnaryCallable in decorateCheckAndMutateRow to ensure proper tracing and consistency with other decorated methods.
| public UnaryCallable<ConditionalRowMutation, Boolean> decorateCheckAndMutateRow( | ||
| UnaryCallable<ConditionalRowMutation, Boolean> classic, UnaryCallSettings<?, ?> settings) { | ||
| return new DivertingUnaryCallable<>( | ||
| configManager, classic, checkAndMutateRowShim, Util.extractTimeout(settings)); | ||
| } |
There was a problem hiding this comment.
For consistency and to ensure proper tracing/debugging, consider passing debugTagTracer as the fifth argument to DivertingUnaryCallable, similar to how it is done in decorateMutateRow.
@Override
public UnaryCallable<ConditionalRowMutation, Boolean> decorateCheckAndMutateRow(
UnaryCallable<ConditionalRowMutation, Boolean> classic, UnaryCallSettings<?, ?> settings) {
return new DivertingUnaryCallable<>(
configManager, classic, checkAndMutateRowShim, Util.extractTimeout(settings), debugTagTracer);
}
No description provided.