Repository navigation
feat(storage): wire operation metrics in gRPC veneer #14729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nidhiii-27
wants to merge
99
commits into
main
Choose a base branch
from
feat/storage-grpc-veneer-operation-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,542
−225
Open
Changes from all commits
Commits
Show all changes
99 commits
Select commit
Hold shift + click to select a range
07f72be
feat(storage): add OpenTelemetry client metrics infrastructure and co…
nidhiii-27 235a230
fix(storage): resolve code formatting violations for client metrics
nidhiii-27 590ad9e
fix(storage): resolve PR review comments on OpenTelemetry metrics
nidhiii-27 02a7740
fix(storage): resolve code formatting violation in OpenTelemetryBoots…
nidhiii-27 f686723
feat(storage): add OpenTelemetry client metrics instrument registry a…
nidhiii-27 babb702
fix(storage): refactor histogram views and remove deferred connection…
nidhiii-27 22a233f
fix(storage): support transport-derived api label in createClientMete…
nidhiii-27 1f2c146
fix(storage): address review comments for OpenTelemetry client metrics
nidhiii-27 7828fd2
feat(storage): address review feedback on client metrics infra
nidhiii-27 983f248
style(storage): format code with fmt-maven-plugin
nidhiii-27 52cd16a
refactor(storage): address PR review comments for OpenTelemetry clien…
nidhiii-27 18b1e73
fix(storage): resolve review comments for client metrics infra
nidhiii-27 6e7a5c6
refactor(storage): preserve detectedAttributes in buildMeterProvider …
nidhiii-27 57fa64a
fix(metrics): update metric counter units to match Go SDK and design doc
nidhiii-27 f39f525
test(storage): deduplicate instrument nullability assertions in Stora…
nidhiii-27 a1f434d
test(storage): initialize InMemoryMetricReader in @Before and clean u…
nidhiii-27 4607b23
refactor(storage): remove misleading @VisibleForTesting from histogra…
nidhiii-27 97ed050
refactor(storage): remove gcp.storage.client.retries counter [Generat…
nidhiii-27 dc20d62
feat(storage): add OpenTelemetry client metrics configuration and opt…
nidhiii-27 07dcbb1
fix(storage): preserve meterProvider equality across toBuilder and se…
nidhiii-27 434948f
fix(storage): add deserialization guard for metricInterval and update…
nidhiii-27 327b558
fix(storage): address PR review comments for otel metrics config
nidhiii-27 517e61f
style(storage): format StorageOptions classes with fmt-maven-plugin
nidhiii-27 7f624a2
fix(storage): address review comments on otel metrics config
nidhiii-27 4f4f726
fix(storage): clamp metricInterval on deserialization and resolve rev…
nidhiii-27 9519e62
refactor(storage): address PR review comments for client metrics conf…
nidhiii-27 3d889a7
fix(storage): address review comments on PR #14484 for metrics option…
nidhiii-27 e7a3588
test(storage): deduplicate HTTP and gRPC test cases in StorageOptions…
nidhiii-27 ed62afa
feat(storage): add StorageErrorTypeMapper for standard metrics [Gener…
nidhiii-27 edb3def
feat(storage): add StorageMetricsContext for operation metrics state …
nidhiii-27 2b123b7
feat(storage): wire logical operation metrics in Retrying and Storage…
nidhiii-27 261bc60
feat(storage): wire operation metrics in HTTP veneer and storage chan…
nidhiii-27 354f72b
feat(storage): wire operation metrics in gRPC veneer [Generated-by: AI]
nidhiii-27 900248a
refactor(storage): address PR #14728 review comments on StorageMetric…
nidhiii-27 baba83d
Merge branch 'feat/storage-metrics-context' into feat/storage-logical…
nidhiii-27 a8f5f63
Merge branch 'feat/storage-logical-metrics' into feat/storage-veneer-…
nidhiii-27 75b0a0a
Merge branch 'feat/storage-veneer-operation-metrics' into feat/storag…
nidhiii-27 93b51b5
fix(storage): address PR #14729 review comments on gRPC veneer metric…
nidhiii-27 e5d17f3
chore(storage): remove unused helper and duplicate constant in Storag…
nidhiii-27 519a319
Merge branch 'feat/storage-metrics-context-error-mapping' into feat/s…
nidhiii-27 4728da2
feat(storage): add attempt recording methods to StorageMetricsContext…
nidhiii-27 aae49e7
Merge branch 'feat/storage-metrics-context' into feat/storage-logical…
nidhiii-27 f5d0dbe
feat(storage): bind metrics context to retrier and delegate attempt r…
nidhiii-27 dd9d51b
Merge branch 'feat/storage-logical-metrics' into feat/storage-veneer-…
nidhiii-27 de1def9
fix(storage): refine veneer operation metrics context propagation and…
nidhiii-27 230dc75
Merge branch 'feat/storage-veneer-operation-metrics' into feat/storag…
nidhiii-27 bb8cd41
fix(storage): refine gRPC veneer operation metrics and attempt tracking
nidhiii-27 74d10a6
fix(storage): gate status code extraction on rpcSystemName in attempt…
nidhiii-27 198a662
test(storage): consolidate StorageMetricsContextTest and remove unuse…
nidhiii-27 1be4eba
feat(storage): string-type HTTP response status code and set empty st…
nidhiii-27 88ef6d0
Merge branch 'main' into feat/storage-metrics-context-error-mapping
nidhiii-27 8a64086
fix(storage): address PR #14694 review comments in StorageErrorTypeMa…
nidhiii-27 011fdca
Merge branch 'feat/storage-metrics-context-error-mapping' into feat/s…
nidhiii-27 f1afc78
Merge branch 'feat/storage-metrics-context' into feat/storage-logical…
nidhiii-27 bf2048b
refactor(storage): address PR #14695 review comments and move metrics…
nidhiii-27 24f5c19
Merge branch 'feat/storage-logical-metrics' into feat/storage-veneer-…
nidhiii-27 98c266f
refactor(storage): use StorageClientMetrics for context creation in H…
nidhiii-27 7d02a9a
Merge branch 'feat/storage-veneer-operation-metrics' into feat/storag…
nidhiii-27 6b27e7f
refactor(storage): use StorageClientMetrics for context creation in g…
nidhiii-27 c998ce6
refactor(storage): polish StorageErrorTypeMapper cause unwrapping and…
nidhiii-27 ac31ae2
fix(storage): address PR #14695 review comments and readability impro…
nidhiii-27 1ee3ce0
fix(storage): resolve PR comments for StorageErrorTypeMapper
nidhiii-27 46a754f
fix(storage): preserve channel error state, prevent pagination/PCU ov…
nidhiii-27 36fea56
fix(storage): address review feedback on gRPC veneer operation metric…
nidhiii-27 3dbd4e6
fix(storage): address review feedback in StorageMetricsContext
nidhiii-27 295833d
fix(storage): replace StorageStub mock with static TestStorageStub fo…
nidhiii-27 cb8882a
fix(storage): declare gax-httpjson dependency in pom.xml
nidhiii-27 0d4cdde
fix(storage): remove unnecessary gax-httpjson dependency and reference
nidhiii-27 ac00bf4
fix(storage): mock UnaryCallable without annotations for Java 8 compa…
nidhiii-27 a008bbe
fix(storage): resolve PR comments for StorageMetricsContext
nidhiii-27 fd0a88f
fix(storage): address final PR review comments in StorageErrorTypeMapper
nidhiii-27 1244988
fix(storage): record NOT_FOUND on 404, suppress PCU sub-op metrics, a…
nidhiii-27 ce389ea
chore(storage): merge main to resolve spanner test compilation in gap…
nidhiii-27 dfdd5c4
refactor(storage): move mapGaxStatusCode helper below package-private…
nidhiii-27 eaa05b9
fix(storage): record UpdateBucket and UpdateObject metrics on no-op g…
nidhiii-27 1ed0bfc
fix(storage): harden status code extraction in StorageMetricsContext
nidhiii-27 e5aef73
fix(storage): record NOT_FOUND operation metrics on HTTP 404 and extr…
nidhiii-27 a2d2abd
fix(storage): address PR #14698 review comments on 404 attempt metric…
nidhiii-27 9dbb47e
fix(storage): record UpdateBucket and UpdateObject metrics on unmodif…
nidhiii-27 39a9734
Merge branch 'main' into feat/storage-metrics-context-error-mapping
Dhriti07 1de15fc
fix(storage): bound cause depth and simplify gRPC status delegation i…
nidhiii-27 1747bf4
Merge remote-tracking branch 'origin/feat/storage-metrics-context-err…
nidhiii-27 c0daeb7
refactor(storage): address review feedback on StorageMetricsContext
nidhiii-27 2fc50f6
chore(storage): merge main into feat/storage-metrics-context
nidhiii-27 85ee83f
fix(storage): use AttributeKey<Long> with 0L fallback for http.respon…
nidhiii-27 4e3b4a5
Merge branch 'feat/storage-metrics-context' into feat/storage-logical…
Dhriti07 a75f7ab
fix(storage): align StorageMetricsContext and tests after merging bas…
nidhiii-27 26ae991
chore(storage): merge main into feat/storage-logical-metrics
nidhiii-27 fd3c173
chore(storage): merge feat/storage-logical-metrics into feat/storage-…
nidhiii-27 e51bd60
chore(storage): merge feat/storage-veneer-operation-metrics into feat…
nidhiii-27 95ca816
Merge branch 'main' into feat/storage-logical-metrics
Dhriti07 56b54d6
Merge remote-tracking branch 'origin/feat/storage-logical-metrics' in…
nidhiii-27 a7647aa
fix(storage): unwrap IOException causing StorageException in channels…
nidhiii-27 558ee79
Merge branch 'feat/storage-veneer-operation-metrics' into feat/storag…
nidhiii-27 ab73edd
fix(storage): attach multiContext to write/query callables and drop r…
nidhiii-27 ab451f5
Merge remote-tracking branch 'origin/main' into feat/storage-veneer-o…
nidhiii-27 bc57699
fix(storage): short-circuit runNullable when metrics are off and lazi…
nidhiii-27 f1f55dc
Merge branch 'feat/storage-veneer-operation-metrics' into feat/storag…
nidhiii-27 af30054
Merge branch 'main' into feat/storage-grpc-veneer-operation-metrics
nidhiii-27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.