Repository navigation
feat(storage): add gcp.storage.client.response.body.size metric for read operations #14747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nidhiii-27
wants to merge
9
commits into
feat/storage-request-body-size
Choose a base branch
from
feat/storage-response-body-size
base: feat/storage-request-body-size
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,105
−29
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e87b7d9
feat: add gcp.storage.client.response.body.size metric for read opera…
nidhiii-27 404687b
fix(storage): address review feedback and wire blobReadSession respon…
nidhiii-27 98d0b4e
chore(storage): merge feat/storage-request-body-size and extract reco…
nidhiii-27 99caf7c
fix(storage): merge feat/storage-request-body-size and emit gcp.stora…
nidhiii-27 1c66be1
chore(storage): merge feat/storage-request-body-size into feat/storag…
nidhiii-27 b7c3a0d
fix(storage): address PR review comments on response body size metric
nidhiii-27 0179be6
Merge branch 'feat/storage-request-body-size' into feat/storage-respo…
nidhiii-27 21b3fb4
Merge remote-tracking branch 'origin/feat/storage-request-body-size' …
nidhiii-27 a74577e
fix(storage): resolve review comments on response.body.size metric
nidhiii-27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These four
readoverrides repeat the same try/count/capture block. Can we pull that into a smalltrackReadhelper (with a throwing functional interface) so each override is a one-liner?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored by AI Agent