Repository navigation
test(spanner): preserve error message for INTERNAL status in CloudExecutor - #15017
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an operator precedence bug in CloudExecutor.java where string concatenation was evaluated before the null check ternary operator when constructing the internal error description. It also introduces a comprehensive set of unit tests in CloudExecutorTest.java to verify the behavior of toStatus under various error scenarios. I have no feedback to provide.
olavloite
approved these changes
Nov 16, 2026
Contributor
|
Note: I changed the title from 'fix' to 'test'. This does not fix any user-visible bugs, and should therefore not be categorized as a 'fix'. |
sakthivelmanii
deleted the
fix/cloud-executor-internal-status-message
branch
November 16, 2026 10:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CloudExecutor.toStatus(SpannerException), theINTERNALbranch constructs the gRPCStatusdescription without parentheses around the ternary expression fore.getReason() == null.+) has higher operator precedence than equality (==) in Java,(errorMessage + e.getReason()) == nullalways evaluates tofalse, discardingerrorMessageand returning: nullwhene.getReason()isnullor: <reason>when non-null.Solution
CloudExecutor.toStatus(SpannerException)soerrorMessageis preserved forINTERNALerrors.CloudExecutorTestcoveringINTERNALexceptions withnullreason, non-nullErrorInforeason, unpackedrpcStatusdetails, and non-INTERNALerror codes.