Skip to content

fix(bigtable): cap PoolSizer desiredCapacity at maxSessions - #15029

Closed
mutianf wants to merge 2 commits into
googleapis:mainfrom
mutianf:fix-pool-sizer-max-capacity
Closed

mutianf wants to merge 2 commits into
googleapis:mainfrom
mutianf:fix-pool-sizer-max-capacity

Conversation

@mutianf

@mutianf mutianf commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Renames PoolSizer.maxIdleSessions to maxSessions to match SessionPoolConfiguration.max_session_count and caps total desiredCapacity (sessionsInUse + desiredIdleSessions) at maxSessions in PoolSizer.getScaleDelta(). Previously only desiredIdleSessions was clamped, allowing desiredCapacity to exceed max_session_count when sessions were in use or pending RPCs were queued.

Stack

  1. fix(bigtable): cap PoolSizer desiredCapacity at maxSessions #15029 👈
  2. fix(bigtable): remove dead SessionList.inUseSessions and clear PendingVRpc references #15030
  3. fix(bigtable): bound SessionPool pendingRpcs and fast-fail during consecutive failures #15031
  4. fix(bigtable): count pre-OpenSessionResponse stream failures in ChannelPoolDpImpl #15032

@mutianf
mutianf requested review from a team as code owners November 16, 2026 15:29

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request caps the desired capacity of the session pool at the maximum idle sessions limit in PoolSizer.java. It also adds a unit test in PoolSizerTest.java to verify that the scale delta behaves correctly when the capacity is capped. There are no review comments, so we have no feedback to provide.

@mutianf mutianf changed the title fix(bigtable): cap PoolSizer desiredCapacity at maxIdleSessions fix(bigtable): cap PoolSizer desiredCapacity at maxSessions Nov 16, 2026
@mutianf mutianf closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant