Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request caps the desired capacity of the session pool at the maximum idle sessions limit in PoolSizer.java. It also adds a unit test in PoolSizerTest.java to verify that the scale delta behaves correctly when the capacity is capped. There are no review comments, so we have no feedback to provide.
This was referenced Nov 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
PoolSizer.maxIdleSessionstomaxSessionsto matchSessionPoolConfiguration.max_session_countand caps totaldesiredCapacity(sessionsInUse + desiredIdleSessions) atmaxSessionsinPoolSizer.getScaleDelta(). Previously onlydesiredIdleSessionswas clamped, allowingdesiredCapacityto exceedmax_session_countwhen sessions were in use or pending RPCs were queued.Stack