Repository navigation
fix(bigtable): honor per-call retryableCodes in MutateRowsAttemptCallable - #15046
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates MutateRowsAttemptCallable to respect per-call retryable codes from ApiCallContext for both entry-level and RPC-level failures, and adds corresponding unit tests. The reviewer identified an inconsistency in createSyntheticErrorForRpcFailure where it falls back to requestApiException.isRetryable() instead of the stub's configured retryableCodes when no per-call override is present. A code suggestion was provided to align this fallback behavior with createEntryError.
mutianf
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a caller overrides
retryableCodesper call viaApiCallContext.withRetryableCodes(...),MutateRowsAttemptCallablepreviously ignoredcallContext.getRetryableCodes()increateEntryError(always checking the stub defaultthis.retryableCodes) and increateSyntheticErrorForRpcFailure(keepingrequestApiException.isRetryable()computed from the stub default).Changes
callContext.getRetryableCodes()when non-null increateEntryErrorandcreateSyntheticErrorForRpcFailure(falling back to the stub defaultretryableCodes).MutateRowsAttemptCallableTestverifying per-callretryableCodesoverrides for both entry-level and RPC-level errors.