Skip to content

fix(bigquery): clarify Acl append and modify semantics in DatasetInfo.getAcl() - #15049

Merged
jinseopkim0 merged 1 commit into
mainfrom
fix/bigquery-datasetinfo-acl-javadoc
Nov 17, 2026
Merged

jinseopkim0 merged 1 commit into
mainfrom
fix/bigquery-datasetinfo-acl-javadoc

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

b/433885224

DatasetInfo.getAcl() previously labeled its acls.add(...) example as updating dataset ACLs without clarifying that each Acl entry is immutable and add(...) appends a new binding. This clarifies how to append versus modify existing Acl / Acl.Expr entries, documents the DatasetOption.accessPolicyVersion(3) requirement for conditional ACLs, and fixes the broken Access Control doc link.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Javadoc for DatasetInfo.getAcl() to clarify how to update immutable ACL entries and handle conditional ACLs, as well as updating the documentation links. The review feedback correctly points out that BigQuery.DatasetOption.accessPolicyVersion takes a Long parameter instead of an Integer, which would result in a broken Javadoc link, and provides a code suggestion to resolve this.

@jinseopkim0
jinseopkim0 requested a review from lqiu96 November 17, 2026 03:07
@jinseopkim0
jinseopkim0 marked this pull request as ready for review November 17, 2026 03:07
@jinseopkim0
jinseopkim0 requested review from a team as code owners November 17, 2026 03:07
@jinseopkim0
jinseopkim0 merged commit 519e120 into main Nov 17, 2026
205 of 206 checks passed
@jinseopkim0
jinseopkim0 deleted the fix/bigquery-datasetinfo-acl-javadoc branch November 17, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants