Skip to content

ci(bigtable): move emulator ITs to GitHub Actions and clean up CI configs - #15057

Merged
blakeli0 merged 2 commits into
mainfrom
ci-bigtable-emulator-and-cleanup
Nov 17, 2026
Merged

blakeli0 merged 2 commits into
mainfrom
ci-bigtable-emulator-and-cleanup

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor
  • Add .github/workflows/java-bigtable-emulator.yaml to run -Pbigtable-emulator-it on GitHub Actions for fast PR feedback, and remove bigtable-emulator-it (along with the removed bigtable-prod-batch-it profile) from .kokoro/presubmit/bigtable-integration.cfg.
  • Delete .github/workflows/java-bigtable-ci.yaml (redundant with the monorepo .github/workflows/ci.yaml workflow) and obsolete java-bigtable/.cloudbuild/samples_build.yaml.
  • Update java-bigtable/scripts/setup-test-table.sh to default to bigtableadmin.googleapis.com:443 instead of unconditionally looping over test-bigtableadmin.sandbox.googleapis.com:443.

@igorbernstein2
igorbernstein2 requested review from a team as code owners November 17, 2026 18:16

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the setup-test-table.sh script to support single admin host and zone overrides via environment variables or arguments, removing the hardcoded loop over multiple admin hosts. It also simplifies the Kokoro integration test arguments and deletes an unused build configuration file. The review feedback highlights a portability issue in the script where the GNU-specific \b word boundary is used in grep, which could cause failures on macOS or other BSD-based systems. A POSIX-compliant alternative using grep -Eq is suggested to ensure cross-platform compatibility.

@blakeli0
blakeli0 merged commit ca65356 into main Nov 17, 2026
198 checks passed
@blakeli0
blakeli0 deleted the ci-bigtable-emulator-and-cleanup branch November 17, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants