Repository navigation
ci(bigtable): move emulator ITs to GitHub Actions and clean up CI configs - #15057
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the setup-test-table.sh script to support single admin host and zone overrides via environment variables or arguments, removing the hardcoded loop over multiple admin hosts. It also simplifies the Kokoro integration test arguments and deletes an unused build configuration file. The review feedback highlights a portability issue in the script where the GNU-specific \b word boundary is used in grep, which could cause failures on macOS or other BSD-based systems. A POSIX-compliant alternative using grep -Eq is suggested to ensure cross-platform compatibility.
mutianf
approved these changes
Nov 17, 2026
blakeli0
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/java-bigtable-emulator.yamlto run-Pbigtable-emulator-iton GitHub Actions for fast PR feedback, and removebigtable-emulator-it(along with the removedbigtable-prod-batch-itprofile) from.kokoro/presubmit/bigtable-integration.cfg..github/workflows/java-bigtable-ci.yaml(redundant with the monorepo.github/workflows/ci.yamlworkflow) and obsoletejava-bigtable/.cloudbuild/samples_build.yaml.java-bigtable/scripts/setup-test-table.shto default tobigtableadmin.googleapis.com:443instead of unconditionally looping overtest-bigtableadmin.sandbox.googleapis.com:443.