Repository navigation
feat(storage): add gRPC channel readiness telemetry and creation latency recording - #15065
Draft
nidhiii-27 wants to merge 7 commits into
Conversation
…ng and register channel_creation_latency view - Register storage.googleapis.com/internal/client/channel_creation_latency histogram view in OpenTelemetryBootstrappingUtils.createMeterProvider. - Expose MeterProvider from enableGrpcMetrics via GrpcMetricsChannelConfigurator implementing Supplier<MeterProvider> while preserving the existing method signature. - Update getCloudMonitoringEndpoint to support DirectPath over Cloud Interconnect endpoints (storage-direct.googleapis.com, storage-preprod-direct.sandbox.googleapis.com, storage-direct.<universeDomain>, and google-c2p:/// / google-c2p-experimental:/// targets with query/fragment parameters) with defensive null/empty handling. - Add unit tests in OpenTelemetryBootstrappingUtilsTest. [Generated-by: AI]
[Generated-by: AI]
[Generated-by: AI]
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces gRPC channel telemetry and diagnostics to track and record channel creation latency using OpenTelemetry. It adds connectivity state monitoring via a new ChannelReadyWatcher and integrates it into GrpcStorageOptions and OpenTelemetryBootstrappingUtils. Feedback is provided regarding the robust handling of unbracketed IPv6 addresses in extractHostFallback and the removal of setContextClassLoader(null) on the telemetry thread to prevent potential service loading issues in complex environments.
[Generated-by: AI]
…cy recorder [Generated-by: AI]
…/storage-dp-interconnect-channel-readiness
…ncy recording [Generated-by: AI]
nidhiii-27
force-pushed
the
feat/storage-dp-interconnect-channel-readiness
branch
from
November 18, 2026 08:40
e9f3958 to
870eac8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds asynchronous gRPC
channel[0]readiness diagnostics, runtime DNS fallback detection, and OpenTelemetrychannel_creation_latencyrecording for DirectPath over Cloud Interconnect (DP over GCI) ingoogle-cloud-storage.Key Changes
GrpcChannelTelemetry:selectedTransportType,channelReadyNote,logChannelReady) detectinggoogle-c2pDNS (pick_first) fallback and reporting connection readiness latency orgrpc-javalogging guidance.channel[0]readiness watcher (startChannelTelemetry/createChannelPrimer/configureChannelTelemetry) usingWeakReference<ManagedChannel>,ApiClock,notifyWhenStateChanged, reflective LB policy extraction (defaultExtractLbPolicyName), defensive callback/scheduler isolation, and automatic shutdown of a lazily created single-use daemonScheduledExecutorService.GrpcStorageOptions:ChannelConfiguratorfromOpenTelemetryBootstrappingUtils.enableGrpcMetricsand clientApiClockintoGrpcChannelTelemetry.configureChannelTelemetryto wireOpenTelemetryBootstrappingUtils.createChannelCreationLatencyRecorderandChannelPrimeronchannel[0].GrpcChannelTelemetryTest:ChannelPrimerfirst-channel observation and owned-scheduler shutdown, and OpenTelemetrychannel_creation_latencyhistogram recording.