Skip to content

chore(bigtable): add standalone ListInstances sample with imports - #15080

Merged
jinseopkim0 merged 1 commit into
mainfrom
fix/bigtable-list-instances-sample
Nov 19, 2026
Merged

jinseopkim0 merged 1 commit into
mainfrom
fix/bigtable-list-instances-sample

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

Add a standalone ListInstances sample with bigtable_list_instances wrapping the import statements and BigtableInstanceAdminClientV2 client initialization so the rendered documentation snippet is self-contained. Keep the existing region tag in InstanceAdminExample temporarily until DevSite references are updated to ListInstances.java.

b/587900321

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new sample class ListInstances and its corresponding integration test ListInstancesTest to list Cloud Bigtable instances in a specified project. The feedback suggests refactoring the implementation to use the idiomatic, hand-written wrapper client BigtableInstanceAdminClient and its model classes instead of the low-level proto-generated BigtableInstanceAdminClientV2. This refactoring simplifies the code by removing manual proto request construction and requires updating the test assertions to match the simplified output format.

@jinseopkim0
jinseopkim0 requested a review from mutianf November 19, 2026 18:53
@jinseopkim0
jinseopkim0 marked this pull request as ready for review November 19, 2026 18:53
@jinseopkim0
jinseopkim0 requested review from a team as code owners November 19, 2026 18:53
@snippet-bot

snippet-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@jinseopkim0
jinseopkim0 enabled auto-merge (squash) November 19, 2026 18:53
@jinseopkim0
jinseopkim0 merged commit ea012f2 into main Nov 19, 2026
194 checks passed
@jinseopkim0
jinseopkim0 deleted the fix/bigtable-list-instances-sample branch November 19, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants