Repository navigation
test(bigquerystorage): read private table in testSimpleReadWithBackgroundExecutorProvider - #15081
Merged
lqiu96 merged 2 commits intoNov 19, 2026
Merged
Conversation
…oundExecutorProvider Re-enable v1.it.ITBigQueryStorageReadClientTest.testSimpleReadWithBackgroundExecutorProvider and switch it from reading all 164,656 rows of bigquery-public-data.samples.shakespeare to reading a 1-row private table in the test dataset. This test only needs to verify that a custom InstantiatingExecutorProvider is wired onto BigQueryReadClient and can read rows end-to-end. Reading a small private table removes shared public-dataset CreateReadSession load and eliminates the regional endpoint override. Also document in the v1beta1 and v1beta2 @disabled annotations why duplicate public-table read tests stay disabled on non-GA versions (avoiding shared CreateReadSession quota overload across versions while keeping coverage on v1). Fixes b/575539309.
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the 'testSimpleReadWithBackgroundExecutorProvider' integration test in v1 by refactoring it to use a dynamically created temporary table instead of the public Shakespeare table. Additionally, it updates the '@disabled' explanations for several tests in v1beta1 and v1beta2 to clarify that they are disabled to avoid overloading the CreateReadSession quota. Feedback recommends cleaning up the newly created temporary table in the 'finally' block to prevent resource leaks in the test dataset.
Delete the temporary table created in testSimpleReadWithBackgroundExecutorProvider inside the finally block, catching BigQueryException specifically to log cleanup failures without masking test errors or swallowing unrelated exceptions.
jinseopkim0
approved these changes
Nov 19, 2026
lqiu96
enabled auto-merge (squash)
November 19, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable v1.it.ITBigQueryStorageReadClientTest.testSimpleReadWithBackgroundExecutorProvider and switch it from reading all 164,656 rows of bigquery-public-data.samples.shakespeare to reading a 1-row private table in the test dataset.
This test only needs to verify that a custom InstantiatingExecutorProvider is wired onto BigQueryReadClient and can read rows end-to-end. Reading a small private table removes shared public-dataset CreateReadSession load and eliminates the regional endpoint override.
Also document in the v1beta1 and v1beta2 @disabled annotations why duplicate public-table read tests stay disabled on non-GA versions (avoiding shared CreateReadSession quota overload across versions while keeping coverage on v1).
Fixes b/575539309.