Skip to content

test(bigquerystorage): read private table in testSimpleReadWithBackgroundExecutorProvider - #15081

Merged
lqiu96 merged 2 commits into
googleapis:mainfrom
lqiu96:fix/bqstorage-background-executor-it
Nov 19, 2026
Merged

lqiu96 merged 2 commits into
googleapis:mainfrom
lqiu96:fix/bqstorage-background-executor-it

Conversation

@lqiu96

@lqiu96 lqiu96 commented Nov 19, 2026

Copy link
Copy Markdown
Member

Re-enable v1.it.ITBigQueryStorageReadClientTest.testSimpleReadWithBackgroundExecutorProvider and switch it from reading all 164,656 rows of bigquery-public-data.samples.shakespeare to reading a 1-row private table in the test dataset.

This test only needs to verify that a custom InstantiatingExecutorProvider is wired onto BigQueryReadClient and can read rows end-to-end. Reading a small private table removes shared public-dataset CreateReadSession load and eliminates the regional endpoint override.

Also document in the v1beta1 and v1beta2 @disabled annotations why duplicate public-table read tests stay disabled on non-GA versions (avoiding shared CreateReadSession quota overload across versions while keeping coverage on v1).

Fixes b/575539309.

…oundExecutorProvider

Re-enable v1.it.ITBigQueryStorageReadClientTest.testSimpleReadWithBackgroundExecutorProvider and switch it from reading all 164,656 rows of bigquery-public-data.samples.shakespeare to reading a 1-row private table in the test dataset.

This test only needs to verify that a custom InstantiatingExecutorProvider is wired onto BigQueryReadClient and can read rows end-to-end. Reading a small private table removes shared public-dataset CreateReadSession load and eliminates the regional endpoint override.

Also document in the v1beta1 and v1beta2 @disabled annotations why duplicate public-table read tests stay disabled on non-GA versions (avoiding shared CreateReadSession quota overload across versions while keeping coverage on v1).

Fixes b/575539309.
@lqiu96
lqiu96 requested a review from jinseopkim0 November 19, 2026 19:25
@lqiu96
lqiu96 requested review from a team as code owners November 19, 2026 19:25

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables the 'testSimpleReadWithBackgroundExecutorProvider' integration test in v1 by refactoring it to use a dynamically created temporary table instead of the public Shakespeare table. Additionally, it updates the '@disabled' explanations for several tests in v1beta1 and v1beta2 to clarify that they are disabled to avoid overloading the CreateReadSession quota. Feedback recommends cleaning up the newly created temporary table in the 'finally' block to prevent resource leaks in the test dataset.

Delete the temporary table created in testSimpleReadWithBackgroundExecutorProvider inside the finally block, catching BigQueryException specifically to log cleanup failures without masking test errors or swallowing unrelated exceptions.
@lqiu96
lqiu96 enabled auto-merge (squash) November 19, 2026 19:39
@lqiu96
lqiu96 merged commit c329300 into googleapis:main Nov 19, 2026
198 of 199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants