Skip to content

test(error-reporting,logging-winston): increase pack-n-play timeout to 5m - #9672

Draft
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:test/error-reporting-winston-install-timeout
Draft

quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:test/error-reporting-winston-install-timeout

Conversation

@quirogas

Copy link
Copy Markdown
Contributor

Description

This change increases the Mocha timeout for pack-n-play installation system tests.

Impact

This prevents spurious two-minute timeouts during cold npm registry installations.

Changes

  • Increase .timeout(2 * 60 * 1000) to .timeout(5 * 60 * 1000) for TS_CODE_SAMPLES and JS_CODE_SAMPLES in handwritten/error-reporting/system-test/test-install.ts and handwritten/logging-winston/system-test/test-install.ts.

Testing

  • Verified unit tests in handwritten/error-reporting (188 passing) and handwritten/logging-winston (58 passing) under both Node.js and JS_RUNTIME=bun.
  • Verified GIT_DIFF_ARG=origin/main node ./bin/linter.mjs --strict passes with zero errors and zero warnings.
  • Verified pack-n-play (build/system-test/test-install.js) passes locally for both packages.

Alternatives

  • Keeping the 2-minute per-sample Mocha timeout causes intermittent Timeout of 120000ms exceeded failures on CI runners when cold npm registry installs of typescript, @types/node, and gts exceed 120 seconds on the first sample.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the timeout limit for system tests in both handwritten/error-reporting/system-test/test-install.ts and handwritten/logging-winston/system-test/test-install.ts from 2 minutes to 5 minutes. No review comments were provided, and the changes appear straightforward and correct.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant