Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the timeout limit for system tests in both handwritten/error-reporting/system-test/test-install.ts and handwritten/logging-winston/system-test/test-install.ts from 2 minutes to 5 minutes. No review comments were provided, and the changes appear straightforward and correct.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change increases the Mocha timeout for pack-n-play installation system tests.
Impact
This prevents spurious two-minute timeouts during cold npm registry installations.
Changes
.timeout(2 * 60 * 1000)to.timeout(5 * 60 * 1000)forTS_CODE_SAMPLESandJS_CODE_SAMPLESinhandwritten/error-reporting/system-test/test-install.tsandhandwritten/logging-winston/system-test/test-install.ts.Testing
handwritten/error-reporting(188 passing) andhandwritten/logging-winston(58 passing) under both Node.js andJS_RUNTIME=bun.GIT_DIFF_ARG=origin/main node ./bin/linter.mjs --strictpasses with zero errors and zero warnings.pack-n-play(build/system-test/test-install.js) passes locally for both packages.Alternatives
Timeout of 120000ms exceededfailures on CI runners when cold npm registry installs oftypescript,@types/node, andgtsexceed 120 seconds on the first sample.