feat: [Gax] Add script to download and generate the showcase client and download the showcase server#9347
Open
Hectorhammett wants to merge 2 commits into
Open
feat: [Gax] Add script to download and generate the showcase client and download the showcase server#9347Hectorhammett wants to merge 2 commits into
Hectorhammett wants to merge 2 commits into
Conversation
…the showcase server
Hectorhammett
marked this pull request as ready for review
July 16, 2026 22:03
bshaffer
reviewed
Jul 17, 2026
Contributor
There was a problem hiding this comment.
Looks like we aren't generating these clients with MigrationMode::NEW_SURFACE_ONLY. Let's make sure we do that (files in the Gapic namespace should not exist)
Contributor
There was a problem hiding this comment.
Our github actions job installs and runs the gapic-showcase server dynamically, and the bash job should do the same... we shouldn't need to commit a binary, then we'll need to maintain it
# Option 1 (curl)
curl -L https://github.com/googleapis/gapic-showcase/releases/download/v${GAPIC_SHOWCASE_VERSION}/gapic-showcase-${GAPIC_SHOWCASE_VERSION}-${OS}-${ARCH}.tar.gz | tar -zx
./gapic-showcase run
# Option 2 (go get)
go install github.com/googleapis/gapic-showcase/cmd/gapic-showcase
gapic-showcase run
Contributor
There was a problem hiding this comment.
As discussed, it would be great to port this to a PHP command in dev/src/Command instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a script for downloading and generating the showcase client for the conformance tests. This client was generated a long time ago and we need a consistent way to generate and update the showcase client and server, specially with PQC around the corner.
Closes: #9229
Depends on: googleapis/gapic-generator-php#838