feat(storage): Support AppendableWrites to RCU by setting storage_class to RAPID in async write object stream - #18226
Open
chandra-siri wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the asynchronous write object stream to set the storage class of newly created objects to 'RAPID' by default. It also updates the corresponding unit tests to assert that the storage class is correctly set to 'RAPID' in the initial write request. There are no review comments, and I have no feedback to provide.
Contributor
|
Merging |
chandra-siri
changed the title
chandra-siri
changed the title
chandra-siri
added
the
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set
storage_class="RAPID"when creating an object resource for appendable write stream in_AsyncWriteObjectStream.open()if no blob was provided.Changes
packages/google-cloud-storage/google/cloud/storage/asyncio/async_write_object_stream.py, setstorage_class="RAPID"on_storage_v2.Objectinitialization.packages/google-cloud-storage/tests/unit/asyncio/test_async_write_object_stream.py, add unit test assertion verifyingstorage_classis set to"RAPID".