Skip to content

chore(bigquery): ignore case in assertion #18230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-sanche wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −5
Open

chore(bigquery): ignore case in assertion #18230

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13fd7a2
ignore case in assertion
daniel-sanche Aug 26, 2026
272c8f5
assert updated header
daniel-sanche Aug 26, 2026
4985d1b
support either case
daniel-sanche Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/google-cloud-bigquery/tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,14 +1798,20 @@ def test_get_table_sets_user_agent(self):
http.request.assert_called_once_with(
url=mock.ANY,
method="GET",
headers={
"X-Goog-API-Client": expected_user_agent,
"Accept-Encoding": "gzip",
"User-Agent": expected_user_agent,
},
headers=mock.ANY,
data=mock.ANY,
timeout=DEFAULT_TIMEOUT,
)
_, kwargs = http.request.call_args
actual_headers = {k.lower(): v for k, v in kwargs["headers"].items()}
self.assertEqual(
actual_headers,
{
"x-goog-api-client": expected_user_agent,
"accept-encoding": "gzip",
"user-agent": expected_user_agent,
},
)
self.assertIn("my-application/1.2.3", expected_user_agent)

def test_get_iam_policy(self):
Expand Down
Loading