Skip to content

[DRAFT] chore(tests): enable core_deps presubmit check - #18233

Draft
daniel-sanche wants to merge 6 commits into
googleapis:mainfrom
daniel-sanche:reenable_core_deps_presubmit
Draft

[DRAFT] chore(tests): enable core_deps presubmit check#18233
daniel-sanche wants to merge 6 commits into
googleapis:mainfrom
daniel-sanche:reenable_core_deps_presubmit

Conversation

@daniel-sanche

Copy link
Copy Markdown
Contributor

This PR re-enabled the core_deps check on pre-submit, with a few changes.

This test triggers the core_deps_from_source nox session, which will run the unit tests against the unreleased copy of the library present in the codebase

Unlike the previous test:

  • we take advantage of the new sharding system
  • this one only targets handwritten libraries, not all packages in the repo
  • tests are trigged for all handwritten libraries when any core dependency is changed (auth, api_core, proto_plus, etc), or if the test config changed

This change also modified noxfiles, to better support preview packages, and avoid downloading over the network when possible

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new core_deps_from_source test session across multiple packages, updating CI scripts to trigger downstream testing of handwritten packages when core dependencies or CI configurations change. Feedback on these changes highlights the need to type-validate loaded JSON metadata and normalize path strings in ci/get_package_shards.py to prevent potential runtime errors and cross-platform issues. Additionally, the fragile while loops used to locate the packages directory in several package noxfile.py files should be replaced with a more robust generator expression to ensure compatibility with preview packages.

Comment thread ci/get_package_shards.py
Comment thread ci/get_package_shards.py Outdated
Comment thread packages/db-dtypes/noxfile.py
Comment thread packages/google-cloud-documentai-toolbox/noxfile.py
Comment thread packages/google-cloud-ndb/noxfile.py
Comment thread packages/googleapis-common-protos/noxfile.py
Comment thread packages/pandas-gbq/noxfile.py
Comment thread packages/proto-plus/noxfile.py
Comment thread packages/sqlalchemy-bigquery/noxfile.py
Comment thread packages/sqlalchemy-spanner/noxfile.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant