[DRAFT] chore(tests): enable core_deps presubmit check - #18233
Draft
daniel-sanche wants to merge 6 commits into
Draft
[DRAFT] chore(tests): enable core_deps presubmit check#18233daniel-sanche wants to merge 6 commits into
daniel-sanche wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new core_deps_from_source test session across multiple packages, updating CI scripts to trigger downstream testing of handwritten packages when core dependencies or CI configurations change. Feedback on these changes highlights the need to type-validate loaded JSON metadata and normalize path strings in ci/get_package_shards.py to prevent potential runtime errors and cross-platform issues. Additionally, the fragile while loops used to locate the packages directory in several package noxfile.py files should be replaced with a more robust generator expression to ensure compatibility with preview packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enabled the core_deps check on pre-submit, with a few changes.
This test triggers the
core_deps_from_sourcenox session, which will run the unit tests against the unreleased copy of the library present in the codebaseUnlike the previous test:
This change also modified noxfiles, to better support preview packages, and avoid downloading over the network when possible