Skip to content

fix(django-spanner): backslash-escape string literals in quote_value - #18234

Open
Samin061 wants to merge 1 commit into
googleapis:mainfrom
Samin061:django-spanner-quote-value-escape
Open

fix(django-spanner): backslash-escape string literals in quote_value#18234
Samin061 wants to merge 1 commit into
googleapis:mainfrom
Samin061:django-spanner-quote-value-escape

Conversation

@Samin061

Copy link
Copy Markdown
Contributor

quote_value inlines a string value into DDL by wrapping it in single quotes and doubling embedded quotes, but Cloud Spanner GoogleSQL does not treat '' as an escaped quote and the routine never escapes backslashes, so a value beginning with a backslash and a quote closes the literal and the trailing text is parsed as DDL. The Spanner backend sets requires_literal_defaults, so column and table comments and altered defaults reach this method. The db_default and generated-column inlining a few lines above already escape by backslashing the backslash and then the quote, so route quote_value through the same escaping.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@Samin061
Samin061 requested a review from a team as a code owner August 27, 2026 08:25

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the quote_value method in django_spanner/schema.py to properly escape backslashes and single quotes for GoogleSQL string literals, and adds corresponding unit tests. The feedback suggests also escaping literal newlines and carriage returns to prevent syntax errors in Spanner.

# GoogleSQL string literals use backslash escaping; '' quote
# doubling is not recognized, so escape the backslash first and
# then the quote (matching the db_default/generated inlining above).
return "'%s'" % value.replace("\\", "\\\\").replace("'", "\\'")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In GoogleSQL, single-quoted string literals cannot contain literal newlines (\n) or carriage returns (\r). If a string containing these characters is passed to quote_value, it will result in a syntax error in Spanner. To prevent this, we should also escape newlines and carriage returns.

Suggested change
return "'%s'" % value.replace("\\", "\\\\").replace("'", "\\'")
return "'%s'" % value.replace("\\", "\\\\").replace("'", "\\'").replace("\n", "\\n").replace("\r", "\\r")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant