Skip to content

perf(bigtable): resolve O(n^2) performance bottleneck in ReadRowsQuery.add_range #18705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sahananshylaja-glitch wants to merge 1 commit into from
Closed

perf(bigtable): resolve O(n^2) performance bottleneck in ReadRowsQuery.add_range #18705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/google-cloud-bigtable/google/cloud/bigtable/data/read_rows_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,12 @@ def add_range(
Args:
row_range: a range of row keys to add to this query
"""
if row_range not in self.row_ranges:
# Check against a set of string signatures to avoid O(n^2) wrapper reconstruction
if not hasattr(self, "_range_signatures"):
self._range_signatures = set(str(RowRange._from_pb(r)) for r in self._row_set.row_ranges)
signature = str(row_range)
if signature not in self._range_signatures:
self._range_signatures.add(signature)
self._row_set.row_ranges.append(row_range._pb)
Comment thread
sahananshylaja-glitch marked this conversation as resolved.

def shard(self, shard_keys: RowKeySamples) -> ShardedQuery:
Expand Down
Loading