Repository navigation
fix(logging): retain default window for incidental timestamp text - #18713
Open
AliAbouelazm wants to merge 2 commits into
Open
AliAbouelazm wants to merge 2 commits into
AliAbouelazm wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the _add_defaults_to_filter helper in google-cloud-logging to use a regular expression-based tokenizer (_FILTER_TOKENS) for parsing logging filters. This ensures that default timestamp constraints are only skipped when there is an actual comparison or cast on the timestamp field, avoiding false positives from occurrences inside strings, comments, or other field paths. It also adds comprehensive unit tests to verify these scenarios. Feedback suggests handling empty or whitespace-only filters to prevent generating invalid filter strings starting with AND.
AliAbouelazm
marked this pull request as ready for review
October 16, 2026 07:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17338.
The default 24-hour window was skipped whenever a filter contained
timestamp, including JSON field names, labels, and quoted text. This change recognizes the actual timestamp field while keeping strings, escaped quotes, nested paths, and comments separate.Existing timestamp comparisons and documented
cast(timestamp, ...)expressions keep their behavior. Appended defaults also stay outside trailing comments, and comment-only filters receive a valid time constraint.Validation:
No documentation change is needed because this restores the documented default time window.