Skip to content

chore(storage): fix test failures for universe domain and requester pays - #36483

Merged
aandreassa merged 1 commit into
mainfrom
ruby-storage-acceptance-fix
Aug 28, 2026
Merged

chore(storage): fix test failures for universe domain and requester pays#36483
aandreassa merged 1 commit into
mainfrom
ruby-storage-acceptance-fix

Conversation

@aandreassa

@aandreassa aandreassa commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Nightly acceptance crashed the google-cloud-storage suite due to missing secrets (failing to load).

This unblocks CI by:

  1. Adding universe domain secrets to nightly/continuous Kokoro configs, matching presubmit.
  2. Rescuing missing secret errors in universe_domain_test.rb to log and skip instead of crashing.

Follow-up PRs will address individual failing tests once nightly runs again. Bug: 552162906

Example Logs:

[acceptance/storage/universe_domain_test.rb:20](https://cs.corp.google.com/piper///depot/google3/acceptance/storage/universe_domain_test.rb?l=20):in 'File.realpath': No such file or directory @ rb_check_realpath_internal - /secrets/gfile/secret_manager/client-library-test-universe-project-id (Errno::ENOENT)
	from [acceptance/storage/universe_domain_test.rb:20](https://cs.corp.google.com/piper///depot/google3/acceptance/storage/universe_domain_test.rb?l=20):in 'block in <top (required)>'
	from /[h/.gem/gems/minitest-5.27.0/lib/minitest/spec.rb:99](https://cs.corp.google.com/piper///depot/google3/h/.gem/gems/minitest-5.27.0/lib/minitest/spec.rb?l=99):in 'Module#class_eval'
	from /[h/.gem/gems/minitest-5.27.0/lib/minitest/spec.rb:99](https://cs.corp.google.com/piper///depot/google3/h/.gem/gems/minitest-5.27.0/lib/minitest/spec.rb?l=99):in 'Kernel#describe'
	from [acceptance/storage/universe_domain_test.rb:17](https://cs.corp.google.com/piper///depot/google3/acceptance/storage/universe_domain_test.rb?l=17):in '<top (required)>'
	from /[tmp/toys-minitest-script-20260828-4032-vsb1ak.rb:28](https://cs.corp.google.com/piper///depot/google3/tmp/toys-minitest-script-20260828-4032-vsb1ak.rb?l=28):in 'Kernel#load'
	from /[tmp/toys-minitest-script-20260828-4032-vsb1ak.rb:28](https://cs.corp.google.com/piper///depot/google3/tmp/toys-minitest-script-20260828-4032-vsb1ak.rb?l=28):in '<main>'
[2026-08-28 08:04:03 ERROR]  Minitest failed!

Nightly acceptance crashed the `google-cloud-storage` suite due to missing universe domain secrets.

This unblocks CI by:
- Adding universe domain secrets to nightly/continuous Kokoro configs, matching [presubmit](https://github.com/googleapis/google-cloud-ruby/blob/main/.kokoro/presubmit/acceptance.cfg#L32).
- Rescuing missing secret errors in `universe_domain_test.rb` to log and skip instead of crashing.

Follow-up PRs will address individual failing tests once nightly runs.
@aandreassa
aandreassa force-pushed the ruby-storage-acceptance-fix branch from 2856e1c to aa8d3df Compare August 28, 2026 22:19
@aandreassa aandreassa changed the title chore: fix storage universe domain secret loading in acceptance tests chore(storage): fix acceptance test failures for universe domain and requester pays Aug 28, 2026
@aandreassa aandreassa changed the title chore(storage): fix acceptance test failures for universe domain and requester pays chore(storage): fix test failures for universe domain and requester pays Aug 28, 2026
@aandreassa
aandreassa force-pushed the ruby-storage-acceptance-fix branch from aa8d3df to d90c3ee Compare August 28, 2026 22:30
@aandreassa aandreassa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2026
@aandreassa
aandreassa marked this pull request as ready for review August 28, 2026 22:32
@aandreassa
aandreassa requested review from a team and yoshi-approver as code owners August 28, 2026 22:32
@aandreassa
aandreassa merged commit 8d2d7d2 into main Aug 28, 2026
33 of 35 checks passed
@aandreassa
aandreassa deleted the ruby-storage-acceptance-fix branch August 28, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants