Repository navigation
fix: convert iterators to list in t_contents to avoid confusing errors - #3212
Open
yashdhumane wants to merge 1 commit into
Open
yashdhumane wants to merge 1 commit into
yashdhumane wants to merge 1 commit into
Conversation
Passing a reversed() iterator or any non-list iterable to generate_content caused confusing errors like 'contents are required' or 'file uri and mime_type are required' instead of a clear message. Fix converts iterables (generators, reversed, map, etc.) to a list before validation, so they work correctly. Fixes googleapis#1272
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a reversed() iterator or any non-list iterable to generate_content caused confusing errors like 'contents are required' or 'file uri and mime_type are required' instead of a clear message.
Fix converts iterables (generators, reversed, map, etc.) to a list before validation, so they work correctly.
Fixes #1272