refactor(samples): polish 0.2.2 showcase samples with collapsible UI, auto-fade, and literate docs by dkhawk · Pull Request #54 · googlemaps-samples/android-maps3d-samples

dkhawk · 2026-08-21T22:50:15Z

Note

Stacked PR: This pull request is branched off of and targets PR #50 (feature/new_features_with_0.2.2_sdk). It contains reviews, UX refinements, and literate programming enhancements for the 0.2.2 showcase samples.

Summary

This pull request provides comprehensive polish, UI consistency, and literate programming documentation across the Google Maps 3D 0.2.2 showcase samples in Java and Kotlin:

Routes API (RoutesActivity):
- Converted to standard control_panel_routes.xml overlay on activity_common_map.xml.
- Added animated card expand/collapse (TransitionManager), 3-second touch-aware idle auto-fade, and toValidCamera bounds enforcement.
- Comprehensive literate docstrings explaining background directions fetching, polyline decoding, 3D glTF model heading updates, and 60fps tracking loop.
Roadmap Mode (RoadmapModeActivity):
- Standardized collapsible header layout for Map Mode selection (ROADMAP, HYBRID, SATELLITE).
- Integrated touch-aware auto-fade timer and literate documentation.
- Verified on device.
Field of View (FieldOfViewActivity) & Data Visualization (DataVisualizationActivity):
- FOV: Optical dolly-zoom physics (15° to 120°), focal length presets, collapsible header, auto-fade. Verified on device.
- Data Viz: Multi-tier elevation palette for coastal flood simulation with extruded 3D polygons, play/pause scrub controls, and auto-fade.
Advanced Camera Animation (AdvancedCameraAnimationActivity) & Path Following (PathFollowingActivity):
- Camera Animation: Modular step engine (FlyToStep, DwellStep, OrbitStep, KeyframeStep), collapsible status card.
- Path Following: Drone perspective flight, clamped-to-ground defaults, dual polyline elevation layering (inner route on top of base route), and auto-fade.

Code Health & Verification

Spotless Formatting: Fully verified via ./gradlew spotlessCheck.
Compilation: Verified via ./gradlew test assembleDebug.

- Advanced Camera Animation: - Add modular step animation pipeline (FlyToStep, OrbitStep, DwellStep, FlyAroundStep, KeyframeStep). - Add high-altitude San Francisco starting camera view. - Implement full reset and continuous orbit support. - Sync Java, Kotlin, and Jetpack Compose implementations. - Path Following: - Implement two-polyline progress tracking with wide blue base route (lower z-index) and narrow purple progress route (higher z-index). - Use in-place fixed polyline IDs to eliminate rendering flickering. - Default altitude mode to 'Clamp to Ground' with support for Relative to Ground, Relative to Mesh, and Absolute. - Add dynamic path height slider to avoid z-fighting with terrain. - Add collapsible control panel with explicit collapse/expand button, auto-slide dismissal, and subtle idle opacity. - Extract all hardcoded strings into strings.xml resources. - Align Java and Kotlin implementations.

…n with collapsible cards and literate docs

…terate docs

…, auto-fade, and literate docs

…xtrusion, and smoothing

kikoso

See inline comments below.

kikoso · 2026-08-24T05:03:29Z

-        lastTimeNanos = frameTimeNanos
-
-        val stepDistance = followSpeedMps * dt
+        val stepDistance = followSpeedMps * (frameDurationMs / 1000.0)


Assuming a fixed 16ms (frameDurationMs) can cause speed drift under frame drops or on displays with variable/higher refresh rates (90Hz / 120Hz).

Consider measuring actual elapsed wall-clock delta time dt = (now - lastTime) / 1000.0 (as done in RoutesActivity.kt):

val now = System.currentTimeMillis() val dt = (now - lastTime) / 1000.0 lastTime = now elapsedDistance += followSpeedMps * dt

Fixed in 4e290f3! Integrated wall-clock delta time (dt = (now - lastTime) / 1000.0) across both Kotlin and Java PathFollowingActivity implementations.

kikoso · 2026-08-24T05:03:45Z

-  private void run360OrbitSpin() {
-    stopTour();
-    isPlaying = true;
+  private void pauseTour() {


When pauseTour() is called here and the user later clicks Play to unpause, startOrResumeTour() invokes tourAnimator.start(googleMap3D, ...) which resets currentStepIndex = 0 and restarts the tour from Step 1 instead of resuming.

Consider checking whether to resume or start:

if (tourAnimator == null) { tourAnimator = buildTourAnimator(); tourAnimator.start(googleMap3D, animatorListener); } else if (tourAnimator.getCurrentStepIndex() < tourAnimator.getSteps().size()) { tourAnimator.resume(); } else { tourAnimator.start(googleMap3D, animatorListener); }

Fixed in 4e290f3! Updated startOrResumeTour() to resume an in-progress tour via tourAnimator.resume() instead of restarting from Step 1.

kikoso · 2026-08-24T05:03:49Z


  override fun onDestroy() {
    stopSimulation()
+    fadeHandler.removeCallbacks(fadeOutRunnable)


Consider adding onPause() to call stopSimulation() and fadeHandler.removeCallbacks(fadeOutRunnable).

Currently, if the user backgrounds the app, answers a phone call, or locks the device, the simulation coroutine loop continues running and triggering 3D polygon redraws in the background until the Activity is destroyed.

Fixed in 4e290f3! Added onPause() override in both Kotlin and Java DataVisualizationActivity implementations to stop the simulation and clean up fade callbacks.

kikoso · 2026-08-24T05:03:53Z

+    fadeHandler.postDelayed(fadeOutRunnable, 3000L)
+  }
+
+  private fun collapseControls() {


In FieldOfViewActivity and RoadmapModeActivity, collapsing is handled smoothly via TransitionManager.beginDelayedTransition(card) and toggling content.visibility = GONE / VISIBLE.

Consider adopting the same approach here instead of calculating translationY and display density manually. It simplifies the code and automatically adapts to varying screen sizes.

Fixed in 4e290f3! Standardized to TransitionManager.beginDelayedTransition(card) and cardContent.visibility = GONE / VISIBLE across both Kotlin and Java DataVisualizationActivity.

…sume, onPause, and TransitionManager collapse

dkhawk added 4 commits August 20, 2026 17:12

feat(fieldofview,datavisualization): polish FOV and Data Visualizatio…

8731618

…n with collapsible cards and literate docs

feat(roadmapmode): polish Roadmap Mode with collapsible header and li…

8d28dac

…terate docs

feat(routes): polish Routes API sample with collapsible control panel…

f947b51

…, auto-fade, and literate docs

dkhawk requested a review from LoyalAbbas August 21, 2026 22:54

dkhawk added 3 commits August 21, 2026 16:58

docs(samples): augment literate comments explaining 3D coordinates, e…

f6d7d73

…xtrusion, and smoothing

build: untrack and gitignore gradle-daemon-jvm.properties

d262c6d

docs: update copyright headers to 2026 for camera animation step classes

dd6b697

dkhawk requested a review from kikoso August 21, 2026 23:11

kikoso reviewed Aug 24, 2026

View reviewed changes

fix(samples): address PR review feedback on animation timing, tour re…

4e290f3

…sume, onPause, and TransitionManager collapse

dkhawk merged commit 7b1496b into feature/new_features_with_0.2.2_sdk Aug 24, 2026
2 checks passed

dkhawk deleted the feat/dkhawk-review-pr-50 branch August 24, 2026 21:30

Navigation Menu

Uh oh!

refactor(samples): polish 0.2.2 showcase samples with collapsible UI, auto-fade, and literate docs - #54

refactor(samples): polish 0.2.2 showcase samples with collapsible UI, auto-fade, and literate docs#54
dkhawk merged 8 commits into
feature/new_features_with_0.2.2_sdkfrom
feat/dkhawk-review-pr-50

dkhawk commented Aug 21, 2026

Uh oh!

kikoso left a comment •

edited

Loading

Uh oh!

kikoso Aug 24, 2026

Uh oh!

dkhawk Aug 24, 2026

Uh oh!

kikoso Aug 24, 2026

Uh oh!

dkhawk Aug 24, 2026

Uh oh!

kikoso Aug 24, 2026

Uh oh!

dkhawk Aug 24, 2026

Uh oh!

kikoso Aug 24, 2026

Uh oh!

dkhawk Aug 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dkhawk commented Aug 21, 2026

Summary

Code Health & Verification

Uh oh!

kikoso left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kikoso left a comment •

edited

Loading