fix(gmail): preserve rich message bodies in read - #897
Open
jokrasno wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 3e25d9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #889.
Gmail
+readcurrently falls back to the truncated snippet for HTML-only messages and can prefer a short or emptytext/plainalternative over substantially richer HTML. Naive tag stripping also loses link targets, entity decoding, and block structure.This change:
html2text, retaining links and document structureAll fixtures are synthetic; no Gmail account, credentials, or real messages were used.
Validation
The five initial regressions all failed on pristine
a3768d0:They cover richer multipart selection, non-truncation, anchor
hrefpreservation, HTML entity decoding, and block line breaks. The final suite also covers empty and comparable plain-text alternatives.cargo fmt --all -- --checkcargo test -p google-workspace-cli test_read_— 7 passedcargo test -p google-workspace-cli helpers::gmail::— 242 passedcargo build --workspacecargo clippy --workspace -- -D warningsThe two excluded ADC tests mutate
HOMEwhiledirs::home_dir()readsUSERPROFILEon Windows; they are outside the Gmail helper and unchanged by this commit.