Repository navigation
Close the consumed subscription source iterator - #286
Merged
Cito merged 1 commit intoOct 19, 2026
Merged
Conversation
Cito
approved these changes
Oct 19, 2026
Cito
left a comment
Member
There was a problem hiding this comment.
Thank you, this looks like the right way to fix it.
I would only change two minor things, but will do it after merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283.
Close the iterator returned by
aiter(iterable), rather than the iterable wrapper, so subscription cleanup reaches the source actually being consumed.Adds regression tests for explicit close, thrown errors and callback errors, plus a test through
subscribe().Validation: full suites on Python 3.10 and 3.14, required coverage, Ruff and mypy.