chore(deps): apply safe npm audit fixes for Dependabot alerts - #674
Merged
Conversation
Resolves the Dependabot alerts fixable without breaking changes across root, example and example-windows: brace-expansion, js-yaml, shell-quote (incl. the one open critical, in example-windows), ws, joi, launch-editor, qs and @babel/core. Left open (need a major-version bump already deferred separately): uuid in example (tied to jest-junit 17), and xmldom/fast-xml-parser in example-windows (tied to react-native-windows). example-web, example-expo and the example/Gemfile (Ruby) alerts are untouched — same story, or a different ecosystem. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- example-windows/package-lock.json: Generated file
- example/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Dependabot alerts that have a non-breaking fix available (
npm audit fix, no--force) acrosspackage-lock.json(root),example/package-lock.jsonandexample-windows/package-lock.json:brace-expansion— DoS via exponential-time / unbounded expansionjs-yaml— quadratic-complexity DoS in merge-key handlingshell-quote— quadratic-complexity DoS inparse(), including the one open critical alert (newline escaping inexample-windows)ws— memory exhaustion DoS from tiny fragmentsjoi,launch-editor,qs,@babel/core— assorted moderate/low fixesDependabot alerts auto-close once it rescans and sees the fixed versions on
master— no manual linking needed.Left open (need a breaking bump, deliberately out of scope here)
uuidinexample/example-web— forcesjest-junit→ 17.0.0, or downgradeswebpack-dev-serverto 1.16.5 inexample-web.xmldom/fast-xml-parserinexample-windows— tied to areact-native-windowsmajor bump.example-expo— tied to the Expo SDK 55 → 57 bump.example/Gemfile(Ruby:activesupport,concurrent-ruby) — different ecosystem (bundle update), not covered here.These mirror the major-version candidates already called out as deferred in #673.
Test plan
npm run type-check/lint:ci/build(root)npm run lint(example)npm audit— 0 vulnerabilities left in root; only the deferreduuid/jest-junitpair left inexample; only the deferredxmldom/fast-xml-parserpair left inexample-windows🤖 Generated with Claude Code