Prevent proxy credential leakage from URL parse errors - #1732
Merged
groupthinking merged 3 commits intoSep 12, 2026
Merged
groupthinking merged 3 commits into
groupthinking merged 3 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix proxy credential leakage from urlparse errors
Prevent proxy credential leakage from URL parse errors
Sep 8, 2026
groupthinking
approved these changes
Sep 12, 2026
groupthinking
marked this pull request as ready for review
September 12, 2026 09:35
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
groupthinking
deleted the
copilot/groupthinking-fix-proxy-credential-leakage-and-vac
branch
September 12, 2026 09:36
Contributor
🔍 PR Validation |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Outcome
Malformed proxy URLs no longer propagate credential-bearing parse errors, and yt-dlp/transcript failure logs redact proxy userinfo.
Scope
socks5h, helper parity, and credential redaction.Example:
Risk
464a68faa5f914687f4057d097341322e9703518.Verification
Current head:
464a68faa5f914687f4057d097341322e9703518python -m pytest -q --no-cov tests/unit/test_proxy_utils.py— 45 passedProduction evidence
Not applicable; this change affects validation and logging behavior only.
Agent handoff