Skip to content

Prevent proxy credential leakage from URL parse errors - #1732

Merged
groupthinking merged 3 commits into
mainfrom
copilot/groupthinking-fix-proxy-credential-leakage-and-vac
Sep 12, 2026
Merged

groupthinking merged 3 commits into
mainfrom
copilot/groupthinking-fix-proxy-credential-leakage-and-vac

Conversation

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Canonical issue

Outcome

Malformed proxy URLs no longer propagate credential-bearing parse errors, and yt-dlp/transcript failure logs redact proxy userinfo.

Scope

  • Included:
    • Validate proxy ports and supported schemes consistently across canonical and standalone helpers.
    • Sanitize transcript, yt-dlp, Whisper, and metadata failure details before logging or returning them.
    • Add regression coverage for malformed URLs, socks5h, helper parity, and credential redaction.
  • Explicitly excluded:
    • Broader refactoring of unrelated error logging paths.
    • Production deployment changes.

Example:

try:
    parsed = urllib.parse.urlparse(url)
    valid = parsed.scheme in _ALLOWED_SCHEMES and bool(parsed.hostname)
    if valid:
        _ = parsed.port
except ValueError:
    valid = False

Risk

  • Risk level: low
  • Failure mode: Invalid proxy configuration falls back to direct connection; diagnostic details remain redacted.
  • Rollback: Revert commit 464a68faa5f914687f4057d097341322e9703518.

Verification

Current head: 464a68faa5f914687f4057d097341322e9703518

  • Focused tests: python -m pytest -q --no-cov tests/unit/test_proxy_utils.py — 45 passed
  • Required CI — pending/action required
  • Review threads resolved

Production evidence

Not applicable; this change affects validation and logging behavior only.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Sep 12, 2026 9:37am UTC

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix proxy credential leakage from urlparse errors Prevent proxy credential leakage from URL parse errors Sep 8, 2026
Copilot AI requested a review from groupthinking September 8, 2026 23:25
@groupthinking
groupthinking marked this pull request as ready for review September 12, 2026 09:35
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 92aa20ff-a28c-450b-a5a7-9d23140e7c13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@groupthinking
groupthinking merged commit 9edcef3 into main Sep 12, 2026
21 of 24 checks passed
@groupthinking
groupthinking deleted the copilot/groupthinking-fix-proxy-credential-leakage-and-vac branch September 12, 2026 09:36
@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ PR title should follow conventional commits format

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 1e08d12.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent proxy credential leakage from urlparse errors

2 participants