Skip to content

Test list videos responsiveness during in-flight scan - #1756

Merged
groupthinking merged 3 commits into
mainfrom
copilot/test-fix-responsiveness-test
Sep 12, 2026
Merged

groupthinking merged 3 commits into
mainfrom
copilot/test-fix-responsiveness-test

Conversation

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Canonical issue

Issue link handled separately.

Outcome

The list-videos responsiveness test now proves loop progress happens while the blocking scan is still running, not merely after a bounded timeout expires.

Scope

  • Included:
    • Timestamp scan completion with time.monotonic().
    • Timestamp loop ticks before releasing the mocked scan.
    • Assert qualifying ticks occurred before scan completion.
    • Failure message names inline event-loop execution.
  • Explicitly excluded:
    • No /api/v1/videos behavior changes.
    • No src/ changes.
concurrent = [t for t in tick_times if t < finished_at["scan"]]
assert len(concurrent) >= 3

Risk

  • Risk level: low
  • Failure mode: test timing sensitivity on unusually constrained runners
  • Rollback: revert the test-only change in tests/unit/test_v1_router_extended.py

Verification

Current head: be11b94

  • Focused tests: python -m pytest tests/unit/test_v1_router_extended.py::TestListVideosOffloading --no-cov -q
  • Required CI
  • Review threads resolved: no validation comments

Production evidence

Not applicable; test-only change.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Sep 12, 2026 9:52am UTC

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix TestListVideosOffloading responsiveness test Test list videos responsiveness during in-flight scan Sep 8, 2026
Copilot AI requested a review from groupthinking September 8, 2026 23:38
@groupthinking
groupthinking marked this pull request as ready for review September 12, 2026 09:51
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1d227049-fb78-4709-95ee-798c59322183

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@groupthinking
groupthinking merged commit 9155bec into main Sep 12, 2026
19 of 21 checks passed
@groupthinking
groupthinking deleted the copilot/test-fix-responsiveness-test branch September 12, 2026 09:51
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA d1f57cc.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ PR title should follow conventional commits format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: TestListVideosOffloading responsiveness test passes against an inline implementation

2 participants