Skip to content

feat(factory): add receipt-bound handoff and MCP proof - #1926

Open
groupthinking wants to merge 4 commits into
mainfrom
codex/mcp-skills-suite-accounting-20260913
Open

feat(factory): add receipt-bound handoff and MCP proof#1926
groupthinking wants to merge 4 commits into
mainfrom
codex/mcp-skills-suite-accounting-20260913

Conversation

@groupthinking

@groupthinking groupthinking commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Outcome

Completes the pinned MCP conformance repair and the bounded fixture-only Video Pack → Agent Factory handoff from #1927.

MCP conformance

  • Pins the official suite at 7169291ec0b68eb370fddcd9947313ab0d5e4156.
  • Accounts for all three Skills server scenarios and five Skills client scenarios as explicit exclusions.
  • Corrects the 2026-07-28 client driver to use the stateless per-request lifecycle instead of the pre-2026 initialize handshake.
  • Commits a machine-readable receipt generated from public implementation commit d7884028c6470b2b1a2e8fb90744b8c16ce23004.
  • Receipt result: all eight currently certified server/client scenarios passed; overall_ok=true.
  • Makes no Skills-conformance claim while the eight Skills scenarios remain excluded.

Fixture-only Factory handoff

  • Converts a sanitized Video Pack App Builder workspace plus mission.canvas into exactly one candidate task.
  • Binds the candidate to pack_id, source_hash, workspace digest, mission-canvas digest, and source canvas node.
  • Generates stable plan revisions and candidate fingerprints.
  • Deduplicates existing fingerprints and invalidates approval when the revision changes.
  • Treats transcript, OCR, canvas, and workspace instructions as untrusted evidence with no authority effect.
  • Holds only visual-proof-dependent candidates when captured keyframes are absent.
  • Emits an inert dry-run receipt with zero external effects and no tool dispatch.

Verification

  • Pinned official suite executed on exact remote implementation commit.
  • Machine-readable receipt regenerated and committed.
  • All eight certified scenarios passed.
  • All eight Skills scenarios appear under explicit exclusions.
  • Factory handoff tests pass.
  • Existing App Builder sandbox tests pass.
  • TypeScript type-check passes.
  • Focused Python harness tests pass.
  • No whitespace errors.

Local focused results:

  • Vitest: 19 passed.
  • Pytest: 7 passed.
  • TypeScript: clean.
  • Official suite: 8/8 configured scenarios passed.

Safety boundary

Fixture-only only. No production endpoint, remote skill execution, deployment, provider call, paid action, message, merge, or secret change is included.

Closes the bounded first slice of #1927. Broader persisted authorization, dispatch, result-fetch, and cancellation work remains separate and must retain human approval gates.

Related: #1640, #1661, #1808, #1655, #1927.

@vercel

vercel Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Canceled Canceled Sep 13, 2026 6:04pm UTC

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5ac1b049-df99-44ca-a7f5-fab7727d975d


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ Large PR detected (2105 lines changed)

@groupthinking groupthinking changed the title [ai] test(mcp): account for official SEP-2640 Skills suite test(mcp): account for official SEP-2640 Skills suite Sep 13, 2026
@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 7a76cf0.
Ensure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Copy Markdown
Owner Author

Execution receipt — 2026-09-13

Action verified on head eeb11ffff5887bc4f322d751f4e1c81ff981805b.

  • Upstream pin is 7169291ec0b68eb370fddcd9947313ab0d5e4156.
  • All three official SEP-2640 server scenarios and five client scenarios are explicitly accounted for as unsupported.
  • The regression guard is present and keeps those exclusions disjoint from certified scenarios.
  • CI passed with 8,357 Python tests; frontend test, frontend lint, Python lint, guards, and production build passed.
  • Coverage, Security, CodeQL, Dependency Review, and Secret Scan passed.
  • E2E failed before test execution because no Vercel preview became available for this PR SHA. This two-file Python-only change had a canceled preview; no E2E success is claimed.
  • The checked machine-readable official-suite receipt has not been regenerated on this branch. Official Skills conformance is not claimed.

I also corrected the title after repository validation showed the initial [ai] prefix violated the conventional-commit title policy. The PR remains draft, open, mergeable, and unmerged.

Next: run the pinned official suite and commit its receipt. Keep the five client scenarios excluded until a real Agent Factory MCP client driver passes the upstream hostile servers.

@groupthinking
groupthinking marked this pull request as ready for review September 13, 2026 17:39
# runs against the upstream hostile servers.
"sep-2640-client-no-prefetch",
"sep-2640-client-verify-digest",
"sep-2640-client-verify-size",

@vercel vercel Bot Sep 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phantom scenario sep-2640-client-verify-unlisted-uri (which does not exist at the pinned upstream conformance commit 7169291e) is still listed in EXCLUSIONS["client"], the unit test's skills_client set, and — as of commit 7a76cf0 — the recorded receipt fixture.

Fix on Vercel

@github-actions github-actions Bot added javascript Pull requests that update javascript code tests labels Sep 13, 2026
@groupthinking groupthinking changed the title test(mcp): account for official SEP-2640 Skills suite feat(factory): add receipt-bound handoff and MCP proof Sep 13, 2026

Copy link
Copy Markdown
Owner Author

Execution receipt — 2026-09-13

  • Head: 7a76cf0a214421fc706535526bad040f11e3f688
  • Implementation commit tested by the receipt: d7884028c6470b2b1a2e8fb90744b8c16ce23004
  • Official conformance pin: 7169291ec0b68eb370fddcd9947313ab0d5e4156
  • Official result: overall_ok=true; 8/8 configured scenarios passed; 8 SEP-2640 Skills scenarios remain explicit exclusions
  • Frontend: 19 focused tests passed
  • Python harness: 7 focused tests passed
  • TypeScript: passed
  • Diff check: passed

During execution the pinned suite exposed a 2026 lifecycle mismatch in the auth fixture. The driver now uses the stateless per-request contract for 2026-07-28 and retains the stateful initialize path for earlier versions.

The PR body and checklist are current. The PR is open, non-draft, and mergeable; merge remains a human approval boundary. No production or paid action occurred.

Copy link
Copy Markdown
Owner Author

Final head verification

Verified head 7a76cf0a214421fc706535526bad040f11e3f688.

  • CI: passed
  • Coverage: passed
  • Security Scan: passed
  • CodeQL: passed
  • Dependency Review: passed
  • Secret Scan: passed
  • Official pinned MCP run: overall_ok=true; 8/8 configured scenarios passed
  • E2E workflow: failed at “Extract Vercel preview URL for this PR”; dependency installation and E2E execution were skipped, so this is not an executed-test failure

PR is open, non-draft, mergeable, and ready for human merge review. No merge or deployment was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code python tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant